Merge PR #277: [WIP] Update processors module to follow style guide

Author: trask

processors/build.gradle.kts

@@ -11,8 +11,14 @@ java {
   targetCompatibility = JavaVersion.VERSION_1_8
 }
 
+// AutoService plugin is applied by otel.java-conventions, but we need to declare the dependency
+// to use @AutoService annotation
+
 dependencies {
+  annotationProcessor("com.google.auto.service:auto-service")
+
   api("io.opentelemetry:opentelemetry-sdk")
+  compileOnly("com.google.auto.service:auto-service")
   compileOnly("io.opentelemetry:opentelemetry-sdk-extension-autoconfigure-spi")
   compileOnly("io.opentelemetry:opentelemetry-api-incubator")
 

processors/src/main/java/io/opentelemetry/contrib/eventbridge/internal/EventToSpanEventBridgeComponentProvider.java

@@ -5,6 +5,7 @@
 
 package io.opentelemetry.contrib.eventbridge.internal;
 
+import com.google.auto.service.AutoService;
 import io.opentelemetry.api.incubator.config.DeclarativeConfigProperties;
 import io.opentelemetry.contrib.eventbridge.EventToSpanEventBridge;
 import io.opentelemetry.sdk.autoconfigure.spi.internal.ComponentProvider;
@@ -16,6 +17,8 @@
  * <p>This class is internal and is hence not for public use. Its APIs are unstable and can change
  * at any time.
  */
+@AutoService(ComponentProvider.class)
+@SuppressWarnings("rawtypes")
 public class EventToSpanEventBridgeComponentProvider
     implements ComponentProvider<LogRecordProcessor> {
 

processors/src/main/java/io/opentelemetry/contrib/filter/FilteringLogRecordProcessor.java

@@ -11,10 +11,10 @@
 import io.opentelemetry.sdk.logs.data.LogRecordData;
 import java.util.function.Predicate;
 
-public class FilteringLogRecordProcessor implements LogRecordProcessor {
+public final class FilteringLogRecordProcessor implements LogRecordProcessor {
 
-  public final LogRecordProcessor delegate;
-  public final Predicate<LogRecordData> predicate;
+  private final LogRecordProcessor delegate;
+  private final Predicate<LogRecordData> predicate;
 
   public FilteringLogRecordProcessor(
       LogRecordProcessor delegate, Predicate<LogRecordData> predicate) {

processors/src/main/resources/META-INF/services/io.opentelemetry.sdk.autoconfigure.spi.internal.ComponentProvider

@@ -35,10 +35,8 @@ public class FilteringLogRecordProcessorTest {
 
   private final InMemoryLogRecordExporter memoryLogRecordExporter =
       InMemoryLogRecordExporter.create();
-  ;
   private final LogRecordProcessor logRecordProcessor =
       SimpleLogRecordProcessor.create(memoryLogRecordExporter);
-  ;
   private final InMemorySpanExporter spansExporter = InMemorySpanExporter.create();
   private AutoConfiguredOpenTelemetrySdkBuilder sdkBuilder;
   private Logger logger;
@@ -79,7 +77,7 @@ public SdkLoggerProviderBuilder apply(
                     logRecordData -> {
                       SpanContext spanContext = logRecordData.getSpanContext();
                       return spanContext.isSampled();
-                    }) {})
+                    }))
             .build()
             .get("TestScope");
   }