-
-
Notifications
You must be signed in to change notification settings - Fork 226
Routing enhancements #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Now that I've got the generators up and running in master, I'll probably rebase this and update. |
Should be rebased and mergebale. |
Since the optional _method parameter is now implemented, the docs definately need to be updated. POST-ing to any url having a "_method" query parameter will override the http verb. So making a POST to /blog/3?_method=DELETE will invoke the DELETE route rather than the POST route. |
My work in this PR is now done. |
Please tell the specification you propose. |
Hi! Sorry for that, it wasn't clear that the current specification allows for empty parameters. Yes, it's supporting put, patch, delete methods like this:
So a I'd love to chat with you about a few future enhancemants I have in mind to better support REST-like APIs, and some other stuff. |
Just added automated tests for URL routing. That should clear up what I was trying to achieve. |
…GET request is made to a static resource or a request is made to a non-existent resource 404 is returned instead of 400
…between strings and troute methods to it
…efaulting to trailing slash and if a request comes in without it, we just append it before searching for the routes
… rejecting other http verbs
…,PATCH,DELETE for browsers incapable of sending them
…d a warning if the number of supplied parameters is not exactly the same as expected
Rebased changes onto origin/master. |
+1 |
REST support was implemented. |
Please review my changes carefully. Will recommend reviewing commit by commit, and using ?w=1 parameter to avoid seeing indentation changes as additions/removals.
!!As I could not get master running correctly on my machine, I worked on top of 1.7.5.
Will probably need some merging and conflict resolution, sorry!.
My pull request:
Todo:
update documentation about support for put, patch, delete