Handle empty and duplicate namespace definitions #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In highly concurrent contexts, the INSERT INTO command with the same values can be executed concurrently, leading to duplicate key exceptions. This change makes two adjustments: 1. It is a common pattern to add an empty namespace prefix, referring to the current document, but that is problematic across resources, so those declarations are ignored 2. A StatementException is caught and logged but does not cause the entire request to fail
jholleran
approved these changes
Aug 20, 2019
Member
jholleran
left a comment
jholleran
left a comment
There was a problem hiding this comment.
Looks good. I'll test out these changes when its merged and does it get rid of the 500 errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In highly concurrent contexts, the INSERT INTO command with the same
values can be executed concurrently, leading to duplicate key
exceptions and hence failed requests. This change makes two adjustments:
the current document, but that is problematic across resources, so
those declarations are ignored
entire request to fail