Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: selectbox missing required name (#729) #925

Merged
merged 5 commits into from
Jan 23, 2024
Merged

Conversation

severinlandolt
Copy link
Member

  • add name and required for Select

  • add name and required for MultiSelect and SearchSelect

  • add default select behavior for Select, Multiselect and SearchSelect

  • Update dialog

  • Update icons (chore: icons #896)


Description

Related issue(s)

What kind of change does this PR introduce? (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • New Feature (BREAKING CHANGE which adds functionality)
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

How has this been tested?

Screenshots (if appropriate):

The PR fulfils these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the related issue section above
  • My change requires a change to the documentation. (Managed by Tremor Team)
  • I have added tests to cover my changes
  • Check the "Allow edits from maintainers" option while creating your PR.
  • Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.
  • By contributing to Tremor, you confirm that you have read and agreed to Tremor's CONTRIBUTING.md guideline. You also agree that your contributions will be licensed under the Apache License 2.0 license.

* add name and required for Select

* add name and required for MultiSelect and SearchSelect

* add default select behavior for Select, Multiselect and SearchSelect

* Update dialog

* Update icons (#896)


---------

Co-authored-by: christopherkindl <53372002+christopherkindl@users.noreply.github.com>
Co-authored-by: severinlandolt <sev.landolt@gmail.com>
Co-authored-by: Touha Zohair <39002455+touha98@users.noreply.github.com>
Co-authored-by: mbauchet <maximebauchet26@gmail.com>
Copy link

vercel bot commented Jan 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tremor-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2024 11:02pm

@severinlandolt severinlandolt changed the base branch from beta to main January 23, 2024 18:56
@severinlandolt severinlandolt merged commit 47159be into beta Jan 23, 2024
7 checks passed
Copy link

🎉 This PR is included in version 3.13.4-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

severinlandolt added a commit that referenced this pull request Jan 30, 2024
* fix: selectbox missing required name (#729) (#925)
* add whitesapce nowrap to tooltip

---------

Co-authored-by: jzfrank <77217626+jzfrank@users.noreply.github.com>
Co-authored-by: christopherkindl <53372002+christopherkindl@users.noreply.github.com>
Co-authored-by: Touha Zohair <39002455+touha98@users.noreply.github.com>
Co-authored-by: mbauchet <maximebauchet26@gmail.com>
Co-authored-by: severinlandolt <sev.landolt@gmail.com>
@severinlandolt severinlandolt deleted the beta-select branch February 3, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants