Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/account filtering #9216

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Fix/account filtering #9216

merged 2 commits into from
Aug 22, 2023

Conversation

mroz22
Copy link
Contributor

@mroz22 mroz22 commented Aug 22, 2023

cherry-picks from #9130

current develop has account filtering somewhat broken.

  • filtering by metadata got probably broken in metadata-new-structure branch
  • filtering taproot accounts was probably broken forever

this should fix it.

komret
komret approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@komret komret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I did some quick test, but maybe did not cover everything.

I added this to Issues Suite so that QA can see it. Please provide some instructions for testing.

@mroz22
Copy link
Contributor Author

mroz22 commented Aug 22, 2023

QA tips:

  • try search by account label
  • try seach by default account name (taproot, segwit)..

@mroz22 mroz22 merged commit 625ccb6 into develop Aug 22, 2023
5 checks passed
@mroz22 mroz22 deleted the fix/account-filtering branch August 22, 2023 12:58
@bosomt
Copy link
Contributor

bosomt commented Aug 22, 2023

QA OK

Info:

  • Suite version: desktop 23.9.0 (625ccb6)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuiteDev/23.9.0 Chrome/112.0.5615.204 Electron/24.5.1 Safari/537.36
  • OS: MacIntel
  • Screen: 1440x900
  • Device: Trezor T2T1 2.6.1 regular (revision b151a3db6b04d2bee0bb68470e57b822443bf83d)
  • Transport: BridgeTransport 2.0.33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komret komret komret approved these changes

@tomasklim tomasklim Awaiting requested review from tomasklim

@matejkriz matejkriz Awaiting requested review from matejkriz

Assignees
No one assigned
Labels
None yet
Projects
Issues Suite
Archived in project
Suite Pull Requests
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mroz22 @bosomt @komret