Skip to content

Fix: actually wait for realtime streams to finished #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Fix: actually wait for realtime streams to finished #1520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84e3e0a
Realtime streams fix waiting for streams to finished
ericallam Dec 2, 2024
48789af
Add changeset
ericallam Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/thirty-moose-jam.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@trigger.dev/sdk": patch
---

Fix for waiting for realtime streams to finish
4 changes: 2 additions & 2 deletions packages/core/src/v3/runMetadata/manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ export class StandardMetadataManager implements RunMetadataManager {
return streamInstance;
} catch (error) {
// Clean up metadata key if stream creation fails
this.deleteKey(`$$stream.${key}`);
this.removeFromKey(`$$streams`, key);
throw error;
}
}
Expand All @@ -265,7 +265,7 @@ export class StandardMetadataManager implements RunMetadataManager {
return;
}

const promises = Array.from(this.activeStreams.values());
const promises = Array.from(this.activeStreams.values()).map((stream) => stream.wait());

try {
await Promise.race([
Expand Down