-
-
Notifications
You must be signed in to change notification settings - Fork 823
Fix v4 build workflow #1894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix v4 build workflow #1894
Conversation
|
WalkthroughThe pull request modifies the GitHub Actions workflow by commenting out the Changes
Sequence Diagram(s)sequenceDiagram
participant Repo as Repository
participant Workflow as Workflow Runner
participant Build as Build Job
Repo->>Workflow: Trigger workflow on push/tag
%% Previously: Workflow->>CheckBranch: Evaluate branch condition
Workflow->>Build: Execute build job directly (branch check removed)
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/publish-worker-re2.yml (1)
21-28
: Temporarily Disabled Branch Check JobThe
check-branch
job has been commented out as intended for this temporary fix. However, please add a descriptive TODO or comment clarifying the reason for its disablement (e.g., branch check failing) along with a plan to re-enable it once the appropriate fix is implemented.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/publish-worker-re2.yml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
- GitHub Check: typecheck / typecheck
- GitHub Check: units / 🧪 Unit Tests
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (1)
.github/workflows/publish-worker-re2.yml (1)
30-30
: Disabled Dependency on Branch CheckThe dependency (
needs: check-branch
) in thebuild
job has been commented out in alignment with the temporary branch check removal. Ensure this removal does not inadvertently allow unexpected builds and that future re-introduction of the branch check job is coordinated with any dependent workflow changes.
The branch check didn't quite work as expected so it's disabled now until we fix it.
Summary by CodeRabbit