Skip to content

Chore(webapp): adds more copy buttons #2529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 19, 2025
Merged

Chore(webapp): adds more copy buttons #2529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8725edf
Pass up asChild
samejr Sep 18, 2025
f0a3abe
Include padding when asChild specified
samejr Sep 18, 2025
36a88de
Adds copy buttons to useful data in Details tab
samejr Sep 19, 2025
cc75583
Improve view batch tooltip message
samejr Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apps/webapp/app/components/primitives/CopyableText.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,12 @@ export function CopyableText({
value,
copyValue,
className,
asChild,
}: {
value: string;
copyValue?: string;
className?: string;
asChild?: boolean;
}) {
const [isHovered, setIsHovered] = useState(false);
const { copy, copied } = useCopy(copyValue ?? value);
Expand All @@ -35,6 +37,7 @@ export function CopyableText({
<span
className={cn(
"ml-1 flex size-6 items-center justify-center rounded border border-charcoal-650 bg-charcoal-750",
asChild && "p-1",
copied
? "text-green-500"
: "text-text-dimmed hover:border-charcoal-600 hover:bg-charcoal-700 hover:text-text-bright"
Expand All @@ -50,6 +53,7 @@ export function CopyableText({
content={copied ? "Copied!" : "Copy"}
className="font-sans"
disableHoverableContent
asChild={asChild}
/>
</span>
</span>
Expand Down
204 changes: 136 additions & 68 deletions ...zationSlug.projects.$projectParam.env.$envParam.runs.$runParam.spans.$spanParam/route.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import { assertNever } from "assert-never";
import { useEffect } from "react";
import { typedjson, useTypedFetcher } from "remix-typedjson";
import { ExitIcon } from "~/assets/icons/ExitIcon";
import { FlagIcon } from "~/assets/icons/RegionIcons";
import { AdminDebugRun } from "~/components/admin/debugRun";
import { CodeBlock } from "~/components/code/CodeBlock";
import { EnvironmentCombo } from "~/components/environments/EnvironmentLabel";
Expand All @@ -22,6 +23,7 @@ import { MachineLabelCombo } from "~/components/MachineLabelCombo";
import { MachineTooltipInfo } from "~/components/MachineTooltipInfo";
import { Button, LinkButton } from "~/components/primitives/Buttons";
import { Callout } from "~/components/primitives/Callout";
import { CopyableText } from "~/components/primitives/CopyableText";
import { DateTime, DateTimeAccurate } from "~/components/primitives/DateTime";
import { Header2, Header3 } from "~/components/primitives/Headers";
import { Paragraph } from "~/components/primitives/Paragraph";
Expand Down Expand Up @@ -76,7 +78,6 @@ import {
} from "~/utils/pathBuilder";
import { createTimelineSpanEventsFromSpanEvents } from "~/utils/timelineSpanEvents";
import { CompleteWaitpointForm } from "../resources.orgs.$organizationSlug.projects.$projectParam.env.$envParam.waitpoints.$waitpointFriendlyId.complete/route";
import { FlagIcon } from "~/assets/icons/RegionIcons";

export const loader = async ({ request, params }: LoaderFunctionArgs) => {
const { projectParam, organizationSlug, envParam, runParam, spanParam } =
Expand Down Expand Up @@ -409,6 +410,7 @@ function RunBody({
<SimpleTooltip
button={<TaskRunStatusCombo status={run.status} />}
content={descriptionForTaskRunStatus(run.status)}
disableHoverableContent
/>
</Property.Value>
</Property.Item>
Expand All @@ -422,82 +424,129 @@ function RunBody({
tasks: [run.taskIdentifier],
})}
>
{run.taskIdentifier}
<CopyableText
value={run.taskIdentifier}
copyValue={run.taskIdentifier}
asChild
/>
</TextLink>
}
content={`Filter runs by ${run.taskIdentifier}`}
content={`View runs filtered by ${run.taskIdentifier}`}
disableHoverableContent
/>
</Property.Value>
</Property.Item>
{run.relationships.root ? (
run.relationships.root.isParent ? (
<Property.Item>
<Property.Label>Root & Parent</Property.Label>
<Property.Label>Root & Parent run</Property.Label>
<Property.Value>
<TextLink
to={v3RunSpanPath(
organization,
project,
environment,
{
friendlyId: run.relationships.root.friendlyId,
},
{ spanId: run.relationships.root.spanId }
)}
className="group flex flex-wrap items-center gap-x-1 gap-y-0"
>
{run.relationships.root.taskIdentifier}
<span className="break-all text-text-dimmed transition-colors group-hover:text-text-bright/80">
({run.relationships.root.friendlyId})
</span>
</TextLink>
</Property.Value>
</Property.Item>
) : (
<>
<Property.Item>
<Property.Label>Root</Property.Label>
<Property.Value>
<TextLink
to={v3RunSpanPath(
organization,
project,
environment,
{
friendlyId: run.relationships.root.friendlyId,
},
{ spanId: run.relationships.root.spanId }
)}
className="group flex flex-wrap items-center gap-x-1 gap-y-0"
>
{run.relationships.root.taskIdentifier}
<span className="break-all text-text-dimmed transition-colors group-hover:text-text-bright/80">
({run.relationships.root.friendlyId})
</span>
</TextLink>
</Property.Value>
</Property.Item>
{run.relationships.parent ? (
<Property.Item>
<Property.Label>Parent</Property.Label>
<Property.Value>
<SimpleTooltip
button={
<TextLink
to={v3RunSpanPath(
organization,
project,
environment,
{
friendlyId: run.relationships.parent.friendlyId,
friendlyId: run.relationships.root.friendlyId,
},
{ spanId: run.relationships.parent.spanId }
{ spanId: run.relationships.root.spanId }
)}
className="group flex flex-wrap items-center gap-x-1 gap-y-0"
>
{run.relationships.parent.taskIdentifier}
<CopyableText
value={run.relationships.root.taskIdentifier}
copyValue={run.relationships.root.taskIdentifier}
asChild
/>
<span className="break-all text-text-dimmed transition-colors group-hover:text-text-bright/80">
({run.relationships.parent.friendlyId})
<CopyableText
value={run.relationships.root.friendlyId}
copyValue={run.relationships.root.friendlyId}
asChild
/>
</span>
</TextLink>
}
content={`Jump to root/parent run`}
disableHoverableContent
/>
</Property.Value>
</Property.Item>
) : (
<>
<Property.Item>
<Property.Label>Root run</Property.Label>
<Property.Value>
<SimpleTooltip
button={
<TextLink
to={v3RunSpanPath(
organization,
project,
environment,
{
friendlyId: run.relationships.root.friendlyId,
},
{ spanId: run.relationships.root.spanId }
)}
className="group flex flex-wrap items-center gap-x-1 gap-y-0"
>
<CopyableText
value={run.relationships.root.taskIdentifier}
copyValue={run.relationships.root.taskIdentifier}
asChild
/>
<span className="break-all text-text-dimmed transition-colors group-hover:text-text-bright/80">
<CopyableText
value={run.relationships.root.friendlyId}
copyValue={run.relationships.root.friendlyId}
asChild
/>
</span>
</TextLink>
}
content={`Jump to root run`}
disableHoverableContent
/>
</Property.Value>
</Property.Item>
{run.relationships.parent ? (
<Property.Item>
<Property.Label>Parent run</Property.Label>
<Property.Value>
<SimpleTooltip
button={
<TextLink
to={v3RunSpanPath(
organization,
project,
environment,
{
friendlyId: run.relationships.parent.friendlyId,
},
{ spanId: run.relationships.parent.spanId }
)}
className="group flex flex-wrap items-center gap-x-1 gap-y-0"
>
<CopyableText
value={run.relationships.parent.taskIdentifier}
copyValue={run.relationships.parent.taskIdentifier}
asChild
/>
<span className="break-all text-text-dimmed transition-colors group-hover:text-text-bright/80">
<CopyableText
value={run.relationships.parent.friendlyId}
copyValue={run.relationships.parent.friendlyId}
asChild
/>
</span>
</TextLink>
}
content={`Jump to parent run`}
disableHoverableContent
/>
</Property.Value>
</Property.Item>
) : null}
Expand All @@ -511,10 +560,15 @@ function RunBody({
<SimpleTooltip
button={
<TextLink to={v3BatchPath(organization, project, environment, run.batch)}>
{run.batch.friendlyId}
<CopyableText
value={run.batch.friendlyId}
copyValue={run.batch.friendlyId}
asChild
/>
</TextLink>
}
content={`Jump to ${run.batch.friendlyId}`}
content={`View batches filtered by ${run.batch.friendlyId}`}
disableHoverableContent
/>
</Property.Value>
</Property.Item>
Expand All @@ -540,7 +594,7 @@ function RunBody({
<Property.Value>
{run.version ? (
environment.type === "DEVELOPMENT" ? (
run.version
<CopyableText value={run.version} copyValue={run.version} asChild />
) : (
<SimpleTooltip
button={
Expand All @@ -553,7 +607,7 @@ function RunBody({
)}
className="group flex flex-wrap items-center gap-x-1 gap-y-0"
>
{run.version}
<CopyableText value={run.version} copyValue={run.version} asChild />
</TextLink>
}
content={"Jump to deployment"}
Expand Down Expand Up @@ -606,13 +660,23 @@ function RunBody({
<Property.Item>
<Property.Label>Replayed from</Property.Label>
<Property.Value>
<TextLink
to={v3RunRedirectPath(organization, project, {
friendlyId: run.replayedFromTaskRunFriendlyId,
})}
>
{run.replayedFromTaskRunFriendlyId}
</TextLink>
<SimpleTooltip
button={
<TextLink
to={v3RunRedirectPath(organization, project, {
friendlyId: run.replayedFromTaskRunFriendlyId,
})}
>
<CopyableText
value={run.replayedFromTaskRunFriendlyId}
copyValue={run.replayedFromTaskRunFriendlyId}
asChild
/>
</TextLink>
}
content={`Jump to replayed run`}
disableHoverableContent
/>
</Property.Value>
</Property.Item>
)}
Expand Down Expand Up @@ -747,11 +811,15 @@ function RunBody({
</Property.Item>
<Property.Item>
<Property.Label>Run ID</Property.Label>
<Property.Value>{run.friendlyId}</Property.Value>
<Property.Value>
<CopyableText value={run.friendlyId} copyValue={run.friendlyId} asChild />
</Property.Value>
</Property.Item>
<Property.Item>
<Property.Label>Internal ID</Property.Label>
<Property.Value>{run.id}</Property.Value>
<Property.Value>
<CopyableText value={run.id} copyValue={run.id} asChild />
</Property.Value>
</Property.Item>
<Property.Item>
<Property.Label>Run Engine</Property.Label>
Expand Down
Loading