Skip to content

feat: enable canceling deployments #2545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 24, 2025
+526 −121
Merged

feat: enable canceling deployments #2545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
26182f8
Add canceledAt to the deployment db schema
myftija Sep 23, 2025
bf5f0eb
Expose an api endpoint to cancel deployments
myftija Sep 23, 2025
2be969f
Show the canceled status description in the dashboard
myftija Sep 23, 2025
4cfdf8b
Enable canceling deployments from the dashboard
myftija Sep 23, 2025
209242f
Show cancelation reason in the deployment details
myftija Sep 24, 2025
8e85316
Make verifyProjectMembership a function for consistency
myftija Sep 24, 2025
4507835
Apply some good 🐰 suggestions
myftija Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/webapp/app/components/runs/v3/DeploymentStatus.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ export const deploymentStatuses: WorkerDeploymentStatus[] = [
"DEPLOYED",
"FAILED",
"TIMED_OUT",
"CANCELED",
];

export function deploymentStatusDescription(status: WorkerDeploymentStatus): string {
Expand Down
102 changes: 0 additions & 102 deletions apps/webapp/app/components/runs/v3/RollbackDeploymentDialog.tsx
View file
Open in desktop

This file was deleted.

6 changes: 6 additions & 0 deletions apps/webapp/app/presenters/v3/DeploymentPresenter.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,9 @@ export class DeploymentPresenter {
deployedAt: true,
createdAt: true,
startedAt: true,
installedAt: true,
canceledAt: true,
canceledReason: true,
git: true,
promotions: {
select: {
Expand Down Expand Up @@ -147,8 +150,11 @@ export class DeploymentPresenter {
status: deployment.status,
createdAt: deployment.createdAt,
startedAt: deployment.startedAt,
installedAt: deployment.installedAt,
builtAt: deployment.builtAt,
deployedAt: deployment.deployedAt,
canceledAt: deployment.canceledAt,
canceledReason: deployment.canceledReason,
tasks: deployment.worker?.tasks,
label: deployment.promotions?.[0]?.label,
environment: {
Expand Down
28 changes: 28 additions & 0 deletions ...anizationSlug.projects.$projectParam.env.$envParam.deployments.$deploymentParam/route.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,22 @@ export default function Page() {
/>
</Property.Value>
</Property.Item>
{deployment.canceledAt && (
<Property.Item>
<Property.Label>Canceled at</Property.Label>
<Property.Value>
<>
<DateTimeAccurate date={deployment.canceledAt} /> UTC
</>
</Property.Value>
</Property.Item>
)}
{deployment.canceledReason && (
<Property.Item>
<Property.Label>Cancelation reason</Property.Label>
<Property.Value>{deployment.canceledReason}</Property.Value>
</Property.Item>
)}
<Property.Item>
<Property.Label>Tasks</Property.Label>
<Property.Value>{deployment.tasks ? deployment.tasks.length : "–"}</Property.Value>
Expand Down Expand Up @@ -200,6 +216,18 @@ export default function Page() {
)}
</Property.Value>
</Property.Item>
<Property.Item>
<Property.Label>Installed at</Property.Label>
<Property.Value>
{deployment.installedAt ? (
<>
<DateTimeAccurate date={deployment.installedAt} /> UTC
</>
) : (
"–"
)}
</Property.Value>
</Property.Item>
<Property.Item>
<Property.Label>Built at</Property.Label>
<Property.Value>
Expand Down
Loading
Loading