Skip to content

Make Helm webapp chart images configurable #2573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Make Helm webapp chart images configurable #2573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hosting/k8s/helm/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: trigger
description: The official Trigger.dev Helm chart
type: application
version: 4.0.1
version: 4.0.2
appVersion: v4.0.4
home: https://trigger.dev
sources:
Expand Down
6 changes: 4 additions & 2 deletions hosting/k8s/helm/templates/webapp.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ spec:
{{- end }}
initContainers:
- name: init-shared
image: busybox:1.35
image: "{{ .Values.webapp.initImage.registry }}/{{ .Values.webapp.initImage.repository }}:{{ .Values.webapp.initImage.tag }}"
imagePullPolicy: {{ .Values.webapp.initImage.pullPolicy }}
command: ['sh', '-c', 'mkdir -p /home/node/shared']
securityContext:
runAsUser: 1000
Expand All @@ -77,7 +78,8 @@ spec:
mountPath: /home/node/shared
containers:
- name: token-syncer
image: bitnami/kubectl:1.28
image: "{{ .Values.webapp.tokenSyncerImage.registry }}/{{ .Values.webapp.tokenSyncerImage.repository }}:{{ .Values.webapp.tokenSyncerImage.tag }}"
imagePullPolicy: {{ .Values.webapp.tokenSyncerImage.pullPolicy }}
securityContext:
runAsUser: 1000
runAsNonRoot: true
Expand Down
14 changes: 14 additions & 0 deletions hosting/k8s/helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,20 @@ webapp:
tag: "" # Defaults to Chart.appVersion when empty
pullPolicy: IfNotPresent

# Init container image configuration
initImage:
registry: docker.io
repository: busybox
tag: "1.35"
pullPolicy: IfNotPresent

# Token syncer image configuration
tokenSyncerImage:
registry: docker.io
repository: bitnami/kubectl
tag: "1.28"
pullPolicy: IfNotPresent

# Origin configuration
appOrigin: "http://localhost:3040"
loginOrigin: "http://localhost:3040"
Expand Down