Skip to content

Conversation

wesleymatosdev
Copy link
Contributor

@wesleymatosdev wesleymatosdev commented Aug 12, 2023

/claim #206

  • test: add test to no-duplicated-task-keys rule
  • feat: implement no-duplicated-task-keys
  • chore: create testing scripts
  • refactor: fill in rule meta
  • feat: export no-duplicated-task-keys rule
  • chore: bump package version to 0.0.1

@changeset-bot
Copy link

changeset-bot bot commented Aug 12, 2023

🦋 Changeset detected

Latest commit: 7fbc259

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@trigger.dev/eslint-plugin Patch
@examples/nextjs Patch
@trigger.dev/tailwind-config Patch
@trigger.dev/tsconfig Patch
@trigger.dev/cli Patch
@trigger.dev/core Patch
@trigger.dev/express Patch
@trigger.dev/integration-kit Patch
@trigger.dev/nextjs Patch
@trigger.dev/react Patch
@trigger.dev/sdk Patch
@trigger.dev/github Patch
@trigger.dev/openai Patch
@trigger.dev/plain Patch
@trigger.dev/resend Patch
@trigger.dev/sendgrid Patch
@trigger.dev/slack Patch
@trigger.dev/stripe Patch
@trigger.dev/supabase Patch
@trigger.dev/typeform Patch
@examples/job-catalog Patch
@examples/jobs-starter Patch
nextjs-12 Patch
@examples/package-tester Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wesleymatosdev
Copy link
Contributor Author

@ericallam got the rule working (you can enter config-packages/eslint-config-custom and run pnpm test or pnpm test:watch to take a look at it working).

@wesleymatosdev
Copy link
Contributor Author

Although the rule was successfully implemented, I hadn't success in getting it to validate an actual code. It would be nice to get some help on doing so, if possible 😄

@matt-aitken
Copy link
Member

@ologbonowiwi this is great. I think the idea was that this would be a published package, so it would live in the packages folder and be public. That way we could get the CLI to install it so people can use it. (We'd have manual installation as well).

@wesleymatosdev
Copy link
Contributor Author

wesleymatosdev commented Aug 14, 2023

@matt-aitken fixed it to match what we currently need.

To test it, you can enter any file examples/nextjs-example with access to jobs, create a job with a duplicated key and run pnpm lint.

The expectation is that you'll see the error on your console.

@matt-aitken matt-aitken merged commit 74686c0 into triggerdotdev:main Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants