Skip to content

refactor: remove .js extension from cli package #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

wesleymatosdev
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Aug 17, 2023

⚠️ No Changeset found

Latest commit: 68daf6a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@ericallam ericallam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any changes here that change the tsconfig or whatever was causing these .js extensions to be added. Let's make sure these don't get added back in whenever a file is saved

@wesleymatosdev
Copy link
Contributor Author

This was the PR changing tsconfig.json @ericallam: https://github.com/triggerdotdev/trigger.dev/pull/326/files#diff-e22aa51eb6958a226e8ab3fe57f572e6ca93c2fc23a27d9e03f2a193a5f71d3b

@ericallam ericallam merged commit 83bcefe into triggerdotdev:main Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants