Skip to content

fix: CLI dev command doesn't work if you're already running ngrok #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2023
Merged

fix: CLI dev command doesn't work if you're already running ngrok #407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64f3e1f
fix: CLI dev command doesn't work if you're already running ngrok
Chigala Aug 26, 2023
7ffdc6c
added changeset
Chigala Aug 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/lovely-beers-collect.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@trigger.dev/cli": patch
---

provided a fix to the CLI dev command tunnel not working if you are already running ngrok
10 changes: 10 additions & 0 deletions packages/cli/src/commands/dev.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,16 @@ async function createTunnel(port: number, spinner: Ora) {
return;
}
}
if (
typeof error.message === "string" &&
error.message.includes("connect ECONNREFUSED 127.0.0.1:4041")
) {
spinner.fail(
`Ngrok failed to create a tunnel for port ${port} because ngrok is already running`
);
return;
}
spinner.fail(`Ngrok failed to create a tunnel for port ${port}.\n${error.message}`);
return;
}
}
Expand Down