-
-
Notifications
You must be signed in to change notification settings - Fork 798
Feat/astro support #466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/astro support #466
Conversation
🦋 Changeset detectedLatest commit: 95cdc4c The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@Chigala I made some changes to the Remix PR before merging it.
Can you make sure that these aren't issues in this PR? I'll continue looking at new framework PRs tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 😸
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 😸
No matter how hard I try,I still end up with some bad syntax here and there😭😅. Thanks @matt-aitken |
Task 1 - Astro Adapter
astro
.examples/astro-example
folder.Task 2 - Add a README.md file
README.md
file inside thepackages/astro
folder.Task 3 - Write the documentation
manual-setup-astro.mdx
file in/docs/_snippets/
.client-adaptors.mdx
page with the astro framework.Task 4 - Update the webapp onboarding
route.tsx
page located in_app.orgs.$organizationSlug.projects.$projectParam.setup.astro
, replaced the<FrameworkComingSoon/>
component with new onboarding steps.FrameworkSelector.tsx
file, add "supported" to the framework you’ve worked on.I didn't include trigger init CLI support for the framework because I don't know what the Trigger team has in mind concerning how to handle initialization for the other separate frameworks. If this is needed I don't mind implementing it. I'll also love your feedback on this!
Also, to run trigger CLI dev command you'll need node v18.14.1 and then comment out the node fetch package and use the native fetch. Talked more about this on discord
/claim #452
/closes #452