Skip to content

Conversation

Chigala
Copy link
Contributor

@Chigala Chigala commented Sep 11, 2023

Task 1 - Astro Adapter

  • Created a new folder in packages called astro.
  • Created a basic Astro project that uses the adapter. Placed it in the examples/astro-example folder.
  • Included a basic Job in the Astro project
  • Provide a screenshot of your terminal and the dashboard showing that the Adapter is working.
Screenshot 2023-09-11 at 4 58 38 AM Screenshot 2023-09-11 at 5 00 07 AM Screenshot 2023-09-11 at 5 00 28 AM

Task 2 - Add a README.md file

  • Created a new README.md file inside the packages/astro folder.

Task 3 - Write the documentation

  • Added the astro. manual-setup-guide manual-setup-astro.mdx file in /docs/_snippets/.
  • Updated the table at the bottom of the client-adaptors.mdx page with the astro framework.

Task 4 - Update the webapp onboarding

  • In the route.tsx page located in _app.orgs.$organizationSlug.projects.$projectParam.setup.astro, replaced the <FrameworkComingSoon/> component with new onboarding steps.
  • In the FrameworkSelector.tsx file, add "supported" to the framework you’ve worked on.

I didn't include trigger init CLI support for the framework because I don't know what the Trigger team has in mind concerning how to handle initialization for the other separate frameworks. If this is needed I don't mind implementing it. I'll also love your feedback on this!

Also, to run trigger CLI dev command you'll need node v18.14.1 and then comment out the node fetch package and use the native fetch. Talked more about this on discord

/claim #452
/closes #452

@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2023

🦋 Changeset detected

Latest commit: 95cdc4c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@trigger.dev/astro Patch
astro-example Patch
@trigger.dev/tailwind-config Patch
@trigger.dev/tsconfig Patch
@trigger.dev/cli Patch
@trigger.dev/core Patch
@trigger.dev/eslint-plugin Patch
@trigger.dev/express Patch
@trigger.dev/integration-kit Patch
@trigger.dev/nextjs Patch
@trigger.dev/react Patch
@trigger.dev/remix Patch
@trigger.dev/testing Patch
@trigger.dev/sdk Patch
@trigger.dev/airtable Patch
@trigger.dev/github Patch
@trigger.dev/openai Patch
@trigger.dev/plain Patch
@trigger.dev/resend Patch
@trigger.dev/sendgrid Patch
@trigger.dev/slack Patch
@trigger.dev/stripe Patch
@trigger.dev/supabase Patch
@trigger.dev/typeform Patch
@examples/job-catalog Patch
@examples/unit-testing Patch
perf Patch
@examples/jobs-starter Patch
nextjs-12 Patch
@examples/nextjs Patch
@examples/package-tester Patch
@examples/remix Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matt-aitken
Copy link
Member

@Chigala I made some changes to the Remix PR before merging it.

  • The blank project page in the app was broken – there was a button with no text so it was just a rectangle. I also improved the text a bit.
  • I made some of the docs a bit more specific
  • Some tsconfig paths were missing
  • "next" was a dependency of the remix package
  • A specific version of Remix was in the main dependencies of the package. This would have caused issues with users who were on different versions. I moved it do be a devDependency only.

Can you make sure that these aren't issues in this PR? I'll continue looking at new framework PRs tomorrow.

Copy link
Member

@matt-aitken matt-aitken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 😸

Copy link
Member

@matt-aitken matt-aitken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😸

@matt-aitken matt-aitken merged commit 1b4db79 into triggerdotdev:main Sep 13, 2023
@Chigala
Copy link
Contributor Author

Chigala commented Sep 13, 2023

No matter how hard I try,I still end up with some bad syntax here and there😭😅. Thanks @matt-aitken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TRI-1255] Framework: support for Astro
2 participants