Skip to content

Indexing errors don't get displayed anywhere #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Oct 11, 2023

Conversation

matt-aitken
Copy link
Member

@matt-aitken matt-aitken commented Oct 11, 2023

Closes #514.

Description

When running npx @trigger.dev/cli@latest dev it can fail because the definitions of your Jobs and Triggers is incorrect. E.g. an intervalTrigger has seconds < 60.

This PR surfaces those errors:

  • Directly in the CLI
  • In the UI on the Environments page

✅ Checklist


Testing

  • There's a new file in the job-catalog called misconfigured, with Jobs that are intentionally misconfigured.
  • The new CLI is backwards compatible with old server versions.
  • The old CLI is compatible with the new server version.
  • A prerelease published package has been tested
  • The recurring staging/prod indexer is working

Changelog

  • PerformEndpointIndexService now does the indexing
  • The CLI polls for the state of the latest index after a file change
  • Use a package in the CLI for retrying/polling
  • Added UI for errors on the Environments page

Screenshots

CleanShot 2023-10-11 at 15 44 26
CleanShot 2023-10-11 at 15 44 13

@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2023

🦋 Changeset detected

Latest commit: 3a9deb2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@trigger.dev/core Patch
@trigger.dev/cli Patch
@trigger.dev/testing Patch
@references/package-tester Patch
astro-example Patch
@references/job-catalog Patch
@references/nextjs Patch
perf Patch
@references/unit-testing Patch
@trigger.dev/tailwind-config Patch
@trigger.dev/tsconfig Patch
@trigger.dev/astro Patch
@trigger.dev/eslint-plugin Patch
@trigger.dev/express Patch
@trigger.dev/integration-kit Patch
@trigger.dev/nestjs Patch
@trigger.dev/nextjs Patch
@trigger.dev/react Patch
@trigger.dev/remix Patch
@trigger.dev/sveltekit Patch
@trigger.dev/sdk Patch
@trigger.dev/airtable Patch
@trigger.dev/github Patch
@trigger.dev/linear Patch
@trigger.dev/openai Patch
@trigger.dev/plain Patch
@trigger.dev/replicate Patch
@trigger.dev/resend Patch
@trigger.dev/sendgrid Patch
@trigger.dev/slack Patch
@trigger.dev/stripe Patch
@trigger.dev/supabase Patch
@trigger.dev/typeform Patch
nestjs-example Patch
@references/remix Patch
svelte-example Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matt-aitken matt-aitken merged commit 50e3d9e into main Oct 11, 2023
@matt-aitken matt-aitken deleted the fix/cli-registration-errors branch October 11, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TRI-1309] Trigger registration errors don't get displayed to the user
1 participant