Return transaction hash #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandro-isaza
approved these changes
Feb 18, 2019
This was referenced May 3, 2025
Closed
Closed
zkrypt-crossbar
referenced
this pull request
in Cramiumlabs/wallet-core
Jun 15, 2025
zkrypt-crossbar
referenced
this pull request
in Cramiumlabs/wallet-core
Jun 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #10, return transaction hash in signing output, since we don't expose non-witness encoding method
Testing instructions
UT passed
Types of changes
it's a minor bugfix change
transaction_hashtoSigningOutputWBitcoinTransactionSignerBitcoinTransactionSignerTestsChecklist
[WIP]if necessary.