Add Ripple Payment transaction and signing #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandro-isaza
approved these changes
Feb 24, 2019
| } | ||
|
|
||
| /// Encodes a 64-bit value into the provided buffer. | ||
| static inline void encode64(uint64_t val, std::vector<uint8_t>& data) { |
There was a problem hiding this comment.
We should consolidate this and the one under Bitcoin.
There was a problem hiding this comment.
Yes, the only difference is endian?
There was a problem hiding this comment.
Yes, let's have something like encode64le and encode64be
src/Ripple/Transaction.h
Outdated
| namespace TW { | ||
| namespace Ripple { | ||
|
|
||
| enum FieldType: int { |
There was a problem hiding this comment.
If this is only used in C++ let's use class enum FieldType: int and change enum cases to just the name like int16
src/Ripple/Transaction.h
Outdated
| }; | ||
|
|
||
| enum TransactionType { | ||
| TransactionTypePayment = 0 |
src/Ripple/BinaryCoding.h
Outdated
|
|
||
| /// Encodes a field type. | ||
| static inline void encodeType(FieldType type, int key, std::vector<uint8_t>& data) { | ||
| int _type = int(type); |
There was a problem hiding this comment.
Suggested change
| int _type = int(type); | |
| const auto typeValue = static_cast<int>(type); |
hewigovens
added a commit
that referenced
this pull request
Feb 26, 2019
* Add ripple tx serialization * rebase master * add TWRippleSigner and tests * continue adding * update java_package * Add xrp/wan/vet logo * use enum class * use static_cast
zkrypt-crossbar
pushed a commit
to Cramiumlabs/wallet-core
that referenced
this pull request
Jun 15, 2025
* Add ripple tx serialization * rebase master * add TWRippleSigner and tests * continue adding * update java_package * Add xrp/wan/vet logo * use enum class * use static_cast
zkrypt-crossbar
pushed a commit
to Cramiumlabs/wallet-core
that referenced
this pull request
Jun 21, 2025
* Add ripple tx serialization * rebase master * add TWRippleSigner and tests * continue adding * update java_package * Add xrp/wan/vet logo * use enum class * use static_cast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #6, we only support non negative / float XRP payment transaction from A to B.
Reference:
Testing instructions
All ripple UT passed
Types of changes
Transaction,SignerandTWRippleSignerChecklist
[WIP]if necessary.