Skip to content

Add blockchain checklist #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2019
Merged

Add blockchain checklist #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a387b1
Add blockchain checklist
alejandro-isaza Feb 16, 2019
8894c4b
Fix submodule hashes
alejandro-isaza Feb 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions docs/Contributing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,17 @@ Since the C language doesn't provide good abstractions for variable-sized arrays

The proto file will be used to generate C++ classes and also classes in each supported client language (Swift, Java, etc.). The code generator will also generate the protobuf serialization code so that library clients don't have to worry about serialization. To generate the Protocol Buffers code run the `tools/generate-files` script when you modify the `src/TrustWalletCore.proto` file.

## Blockchain checklist

When implementing a new blockchain make sure you go through this checklist:
- [ ] Implement functionality in C++. Put it in a subfolder of `src/`.
- [ ] Write unit tests. Put them in a subfolder of `tests/`.
- [ ] Add relevant constants in `TWCointType`, `TWP2SHPrefix`, `TWEthereymChainID`, etc. as necessary.
- [ ] Write interface header in `include/TrustWalletCore` and implement the interface in `src/interface`.
- [ ] Write custom address type if necessary.
- [ ] Write interface for signing transactions.
- [ ] Validate generated code in Android an iOS projects. Write integration tests for each.

## Releasing

### iOS
Expand Down
2 changes: 1 addition & 1 deletion lib/json
Open in desktop
Submodule json updated 116 files
2 changes: 1 addition & 1 deletion lib/protobuf
Open in desktop
Submodule protobuf updated 1119 files
2 changes: 1 addition & 1 deletion swift/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ SPEC CHECKSUMS:

PODFILE CHECKSUM: bcab653390ccf2f8e377a439713b531df60e7b01

COCOAPODS: 1.6.0.beta.2
COCOAPODS: 1.6.0
Loading