Skip to content

Implement STEP file merging using model_step_url #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 18, 2025
Merged

Implement STEP file merging using model_step_url #14

merged 9 commits into from
Oct 18, 2025

Conversation

@MustafaMulla29
Copy link
Contributor

seveibar
seveibar reviewed Oct 18, 2025
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting closer, but 1) make sure there are multiple step models on the board and test with a board (idk where the board part of the step models is in your examples)

@MustafaMulla29
Copy link
Contributor Author

@seveibar should I remove those extra checks from the test?

@MustafaMulla29
Copy link
Contributor Author

How can the snapshot quality be improved?
Individual components quality is good but when it is put on board it has low quality.

seveibar
seveibar approved these changes Oct 18, 2025
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely done /tip $30

@seveibar seveibar merged commit e67f0bc into tscircuit:main Oct 18, 2025
@algora-pbc
Copy link

algora-pbc bot commented Oct 18, 2025

🎉🎈 @MustafaMulla29 has been awarded $30 by tscircuit! 🎈🎊

@MustafaMulla29 MustafaMulla29 deleted the step branch October 19, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seveibar seveibar seveibar approved these changes

Assignees

No one assigned

Labels

💰 Rewarded

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MustafaMulla29 @seveibar