-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mean_recombination_rate() assumes the start of the map is position 0 #844
Comments
Thanks for this @grahamgower. I confess I haven't fully digested this --- mind if we put it on the back burner till the new year? |
Good catch. |
Alternatively, should we require that genetic maps start with zero? |
I'm not sure that we can require genetic maps start with zero. The hapmap files I've seen all start well away from zero. Presumably this is due to lack of information in the telomere region, not because the rate itself is zero. |
Given a genetic map like the example provided in the documentation (reproduced below),
RecombinationMap.mean_recombination_rate()
should give zero weight to the region 0-55550. Ie. it should be calculated to match124.482178 / 100 / (183630013 - 55550)
, but current behaviour is to (effectively) calculate124.482178 / 100 / 183630013
.The text was updated successfully, but these errors were encountered: