Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small update to error message for MSP_ERR_TIME_TRAVEL #2094

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

gtsambos
Copy link
Member

Just a small edit to reflect that this error can also be caused by poor specification of census events

@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #2094 (d2c6059) into main (4e5672a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2094   +/-   ##
=======================================
  Coverage   91.32%   91.32%           
=======================================
  Files          20       20           
  Lines       10889    10889           
  Branches     2270     2270           
=======================================
  Hits         9944     9944           
  Misses        516      516           
  Partials      429      429           
Flag Coverage Δ
C 91.32% <ø> (ø)
python 98.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/util.c 98.62% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e5672a...d2c6059. Read the comment docs.

@gtsambos
Copy link
Member Author

i'm a bit confused; this is passing the pre-commits on my local machine

@gtsambos
Copy link
Member Author

don't have time to fix now but will look again later

@gtsambos
Copy link
Member Author

Seems like you need a very specific version of clang-format to run that part of the pre-commit (the current version is 14.x)

clang-format-6.0 not found, skipping this check

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jeromekelleher
Copy link
Member

Seems like you need a very specific version of clang-format to run that part of the pre-commit (the current version is 14.x)

This is a long running saga - don't ask!

I think you just have a trailing space on the end of one of the lines. Most editors can be configured to delete this.

@mergify mergify bot merged commit e08b94f into tskit-dev:main Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants