Add .ancestor(n) method #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #570 +/- ##
=======================================
Coverage 93.08% 93.09%
=======================================
Files 17 17
Lines 5136 5140 +4
Branches 954 954
=======================================
+ Hits 4781 4785 +4
Misses 235 235
Partials 120 120
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hyanwong
force-pushed
the
ancestor-accessor
branch
from
3c5efd6
to
f6b55b1
Compare
|
It would be nice to merge this. Nothing controversial here, I think. |
And allow __eq__ for ancestors (which contain numpy arrays)
hyanwong
force-pushed
the
ancestor-accessor
branch
from
f6b55b1
to
ce04a9b
Compare
I guess we can flag this for automerging then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And allow eq for ancestors (which contain numpy arrays)
Fixes #569