Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define branch length over root to be zero. #191

Merged

Conversation

jeromekelleher
Copy link
Member

Closes #188.

@codecov
Copy link

codecov bot commented May 28, 2019

Codecov Report

Merging #191 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
+ Coverage   85.95%   85.95%   +<.01%     
==========================================
  Files          16       16              
  Lines        8728     8732       +4     
  Branches     1677     1678       +1     
==========================================
+ Hits         7502     7506       +4     
  Misses        733      733              
  Partials      493      493
Flag Coverage Δ
#c_tests 85.95% <100%> (ø) ⬆️
#python_tests 98.27% <100%> (ø) ⬆️
Impacted Files Coverage Δ
python/tskit/trees.py 98.61% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cca87b...4901218. Read the comment docs.

@jeromekelleher
Copy link
Member Author

Any objections to this @hyanwong? Seems like a straightforward improvement that's unlikely to break people's code (I doubt anyone depends on the current exception-throwing behaviour).

@hyanwong
Copy link
Member

I have no objections.

@jeromekelleher jeromekelleher merged commit 6c536e8 into tskit-dev:master May 28, 2019
@jeromekelleher jeromekelleher deleted the zero-branch-length-at-root branch May 28, 2019 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define branch length over a root = 0?
2 participants