Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change error messages for Python 3.11 #2598

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Conversation

benjeffery
Copy link
Member

@benjeffery benjeffery commented Oct 5, 2022

Part of #2248
Our test suite passes with Python 3.11 if these small changes are applied.
However, we can't yet add it to CI as one of our test dependencies (lshmm) depends on numba which doesn't yet have 3.11 support. (see numba/numba#8304)

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #2598 (7f77e9d) into main (a709954) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2598   +/-   ##
=======================================
  Coverage   93.91%   93.91%           
=======================================
  Files          27       27           
  Lines       27200    27200           
  Branches     1215     1215           
=======================================
  Hits        25544    25544           
  Misses       1622     1622           
  Partials       34       34           
Flag Coverage Δ
c-tests 92.24% <ø> (ø)
lwt-tests 89.05% <ø> (ø)
python-c-tests 73.14% <ø> (ø)
python-tests 98.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a709954...7f77e9d. Read the comment docs.

@jeromekelleher
Copy link
Member

Could just delete these strings? Probably sufficient to catch an AttributeError tbh.

@benjeffery
Copy link
Member Author

Could just delete these strings? Probably sufficient to catch an AttributeError tbh.

Well one would hope that they aren't going to change again! I'm happy with the "or" clause.

@jeromekelleher
Copy link
Member

People will wonder in 10 years time what the first strings were for 😉

@benjeffery
Copy link
Member Author

Cool, I removed the matches.

@jeromekelleher
Copy link
Member

Sorry, thought I'd approved already

@benjeffery benjeffery added the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Oct 6, 2022
@mergify mergify bot merged commit 5a3ebde into tskit-dev:main Oct 6, 2022
@mergify mergify bot removed the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants