Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ft subgoal problem #133

Merged
merged 6 commits into from
Mar 8, 2024
Merged

Ft subgoal problem #133

merged 6 commits into from
Mar 8, 2024

Conversation

saraybakker1
Copy link
Collaborator

added an example with the orientations for the kuka, such that you can completely determine the position and orientation of the kuka robot. simulation done in pybullet still. One thing: might be nice to remove the urdfs from the example folder and put it is in a urdfs folder (with the meshes inside).

…bgoal (subgoal0) still has effect on the planning problem. problem?
…to checks in the example, you can just use the previous commit. If you like the checks, you can use this one :).
@saraybakker1
Copy link
Collaborator Author

last commit is with some checks to see if the orientation is actually considered. If you don't want to checks in the example, you can just use the previous commit. If you like the checks, you can use this one :).

Copy link
Collaborator

@maxspahn maxspahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @saraybakker1 ,

this is really helpful because it is such a common use-case. Also, nice to add a kuka example here.

I want to have more understanding of the evdev issue, and limit the changes to the poetry.lock file before merging, but I will take care of that tomorrow.

Concerning the comment about moving the robot model to the robotmodels repo, that is for the future because it affects not only this PR, but many examples on the develop branch.

I also left some minor comments, which might be interesting for you.

examples/iiwa7.urdf Outdated Show resolved Hide resolved
poetry.lock Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there so much changed in this file?
I understand some changes due to the evdev dependency, but 3334 lines seems excessive. I'll try to limit that.

pyproject.toml Outdated Show resolved Hide resolved
examples/kuka_iiwa_with_orientation.py Outdated Show resolved Hide resolved
examples/kuka_iiwa_with_orientation.py Outdated Show resolved Hide resolved
examples/kuka_iiwa_with_orientation.py Outdated Show resolved Hide resolved
…he forward kinematics computation. Improves code style.
@saraybakker1
Copy link
Collaborator Author

Hi @maxspahn, I saw you adapted the example, are you okay with merging it into main or should I still do some adaptations?

@maxspahn maxspahn merged commit de7f653 into develop Mar 8, 2024
2 checks passed
@maxspahn maxspahn deleted the ft_subgoal_problem branch April 18, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants