-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add table gcp_dataproc_cluster closes #376 #379
Conversation
docs/tables/gcp_dataproc_cluster.md
Outdated
@@ -0,0 +1,44 @@ | |||
# Table: gcp_compute_zone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Table: gcp_compute_zone | |
# Table: gcp_dataproc_cluster |
} | ||
} | ||
|
||
# resource "google_compute_network" "named_test_resource" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove this commented part?
gcp/table_gcp_dataproc_cluster.go
Outdated
} | ||
} | ||
|
||
type ClusterInfo struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this empty structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
# One of the below to hook into a custom network / subnetwork | ||
# network = google_compute_network.named_test_resource.name | ||
subnetwork = "projects/parker-aaa/regions/us-east1/subnetworks/test21" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why has the subnetwork been hard-coded?
Co-authored-by: Ved misra <47312748+misraved@users.noreply.github.com>
Integration test logs
Logs
Example query results
Results