Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use exoplayer for video playback #2753

Closed
1 task done
evant opened this issue Nov 5, 2022 · 5 comments
Closed
1 task done

Use exoplayer for video playback #2753

evant opened this issue Nov 5, 2022 · 5 comments
Milestone
Tusky 24

Comments

@evant
Copy link
Contributor

evant commented Nov 5, 2022

Was looking into addressing #2419 and I'm wondering if there'd be any desire to switch from VideoView to https://exoplayer.dev/. In particular it has a clean separation between the media state and the ui which makes handling configuration changes much easier. I find the api nicer to work with as well and it has more robust support for various media codecs which may or may not be useful.

  • Tusky Version:

  • Android Version:

  • Android Device:

  • Mastodon instance (if applicable):

  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.
@evant evant mentioned this issue Nov 6, 2022
Merged
@connyduck
Copy link
Collaborator

The image viewer/media player has some of the worst code in all of Tusky and needs a complete rewrite. And yes, it should definitely run on AndroidX media3 (which is the future of exoplayer)

@nikclayton
Copy link
Contributor

https://cunnin.me/@josh/109540231998431698 is an example user report where I suspect switching to Exoplayer would fix the problem.

@nikclayton
Copy link
Contributor

@mcclure is migrating from Exoplayer something you're going to tackle?

@mcclure
Copy link
Collaborator

mcclure commented Jan 28, 2023

@mcclure is migrating from Exoplayer something you're going to tackle?

Yes, I have started looking at it and plan to do this in the 22.0 cycle. If it proves too big for me I will report back in Matrix but it seems straightforward.

nikclayton added a commit that referenced this issue Aug 10, 2023
@mcclure
Migrate to androidx-media3 video player (#3857)
8529f30 
Behaviour is consistent with previous player except that:

- Swapping apps while a video is playing, and then returning to Tusky,
will keep the seek position in the video instead of returning to the
start
- The controls/media description can be shown by tapping anywhere, not
just on the video itself
- The media description is on-screen for the same duration as the player
controls (5 seconds here, 3 seconds in the previous code)
- The user has options to control the playback speed
- Rotating the device does not squash/stretch the video
- Show the media preview when playing audio-only files

Fixes #3329,
#3141,
#3126,
#2753,
#3508,
#3291

---------

Co-authored-by: mcc <andi.m.mcclure@gmail.com>
@charlag
Copy link
Collaborator

charlag commented Nov 18, 2023

fixed by #3857

@charlag charlag closed this as completed Nov 18, 2023
@charlag charlag added this to the Tusky 24 milestone Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Tusky 24
Development

No branches or pull requests
5 participants
@mcclure @evant @nikclayton @charlag @connyduck