Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image thumbnails for audio attachments #3291

Closed
1 task done
mcclure opened this issue Feb 9, 2023 · 3 comments
Closed
1 task done

Image thumbnails for audio attachments #3291

mcclure opened this issue Feb 9, 2023 · 3 comments
Milestone

Comments

@mcclure
Copy link
Collaborator

mcclure commented Feb 9, 2023

Consider this status

https://mastodon.social/@mcc/109836577896256495

It has an audio attachment, and the audio attachment has an image thumbnail, which I guess mastodon.social supports now (4.0 feature?). So viewed on mastodon.social this looks like

image

Feature seems worth supporting.


  • Tusky Version: 21.0 (+ trivial patches)

  • Android Version: 12

  • Android Device: Xperia 5 III

  • Mastodon instance (if applicable): mastodon dot social

  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.

@Lakoja
Copy link
Collaborator

Lakoja commented Feb 9, 2023

Slightly related: #3261 which says that controls do not work at all for audio.

@nikclayton
Copy link
Contributor

Fixed in #3857

Looks like this:

nikclayton added a commit that referenced this issue Aug 10, 2023
Behaviour is consistent with previous player except that:

- Swapping apps while a video is playing, and then returning to Tusky,
will keep the seek position in the video instead of returning to the
start
- The controls/media description can be shown by tapping anywhere, not
just on the video itself
- The media description is on-screen for the same duration as the player
controls (5 seconds here, 3 seconds in the previous code)
- The user has options to control the playback speed
- Rotating the device does not squash/stretch the video
- Show the media preview when playing audio-only files

Fixes #3329,
#3141,
#3126,
#2753,
#3508,
#3291

---------

Co-authored-by: mcc <andi.m.mcclure@gmail.com>
@charlag
Copy link
Collaborator

charlag commented Nov 18, 2023

fixed by #3857

@charlag charlag closed this as completed Nov 18, 2023
@charlag charlag added this to the Tusky 24 milestone Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants