Tests: Switch from .then to .done to get synchronous operation #19906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jQuery 3.0 uses Promise/A+ compliant .then method which is always async. The older .done and .fail methods are still sync. Ref: https://jquery.com/upgrade-guide/3.0/
cvrebert
added a commit
that referenced
this pull request
Jun 27, 2016
Closes #19906 [skip validator]
|
Indeed, there's no good reason for these tests to be using Deferreds. Pretty sure they were just copying the skeleton of the other nearby tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the only failure I found in the test suite with jQuery 3.0 and it's easily fixed. 🍕
jQuery 3.0 uses Promise/A+ compliant
.thenmethod which is always async. The older .done and .fail methods are still sync. Ref: https://jquery.com/upgrade-guide/3.0/It's not clear why these two tests use Deferred at all since they appear to be completely synchronous. The giveaway is that there is no QUnit
assert.async()call in the test, which you would need if there was any async component.