-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'Issues assignment' section to the Contributing Guidelines #38616
Merged
mdo
merged 1 commit into
main
from
main-jd-add-issue-assignment-section-to-contributing-guidelines
Jun 1, 2023
Merged
Add 'Issues assignment' section to the Contributing Guidelines #38616
mdo
merged 1 commit into
main
from
main-jd-add-issue-assignment-section-to-contributing-guidelines
Jun 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
mdo
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
mdo
deleted the
main-jd-add-issue-assignment-section-to-contributing-guidelines
branch
June 1, 2023 02:28
This was referenced May 19, 2024
This was referenced May 24, 2024
This was referenced May 24, 2024
This was referenced May 24, 2024
This was referenced Sep 18, 2024
This was referenced Sep 28, 2024
This was referenced Sep 30, 2024
This was referenced Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR suggests adding a new section to our Contributing Guidelines named 'Issues assignment' that explains that we don't assign issues to contributors and why.
Motivation & Context
As maintainers, we often get asked to assign issues to contributors. We don't do that for several reasons.
IMO it's important to explain why we don't do that in our Contributing Guidelines to avoid frustration and confusion for contributors.
On our side, it will allow us having a link to point to when we get asked to assign issues.
On my side, if it is merged, I'll update my GitHub Saved reply to point to this section that I'll be able to share here as a comment right after if you're interested.
Having the same kind of answers would bring consistency and coherence to our answers.
Improvement 1
I wanted to add to this PR a message at the end of all newly created issues (via the issues template) to point to this section but it's not possible to do it. Some sources that confirm it:
So I'll try to provide a GitHub Action later, as a second step, to add this message to all newly created issues.Edit: done via #38622
Improvement 2
Still IMHO, at some point, it would be nice to have a kind of "pr welcome" label to add to issues when they are ready to develop for maintainers or contributors, and/or a kind of "core team only" if this can't be treated outside because of the complexity or any other reasons. It would be a good way to help contributors to find issues to work on and would bring some clarity on who can do what to help us.
Type of changes
Checklist
npm run lint
)Live previews