Fix Reify and reflect for lists of references. Fixes #102 #103
Conversation
|
I propose the following invariant instead:
|
jvm/src/Language/Java.hs
Outdated
| -- reifying induces allocations and copies. | ||
| class Interpretation a => Reify a where | ||
| -- | Invariant: the argument and the result are distinct. That is, the result | ||
| -- and the argument share no direct JVM object references. |
There was a problem hiding this comment.
This is the only relevant condition:
The result and the argument share no direct JVM object references.
The values being distinct does not imply it.
There was a problem hiding this comment.
I'm not sure I get your point. I intended the second sentence as the definition of the word "distinct" in the first sentence. Said definition doesn't mention values. We could choose to remove introducing a definition entirely.
There was a problem hiding this comment.
I see. I find the meaning of distinct surprising here. It would be best to avoid it as you suggest.
jvm/CHANGELOG.md
Outdated
| * The `Reify`/`Reflect` instances for `()` is now mapped to | ||
| a *serializable* small JVM object. This is a more useful instance | ||
| for sparkle users. | ||
| * `Reify`/`Reflect` were given additional pre and post conditions. |
There was a problem hiding this comment.
This should be reformulated a bit.
facundominguez
force-pushed
the
fd/fixrrlists
branch
from
57245ff to
cde66ae
Compare
No description provided.