Develop changes #419

GTrunSec · 2023-01-24T16:54:12Z

add kernels info into passthru

netlify · 2023-01-24T16:54:18Z

✅ Deploy Preview for tweag-jupyterwith ready!

Name	Link
🔨 Latest commit	`3512564`
🔍 Latest deploy log	https://app.netlify.com/sites/tweag-jupyterwith/deploys/63e06d8e28ae91000912c9bc
😎 Deploy Preview	https://deploy-preview-419--tweag-jupyterwith.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

djacu · 2023-01-26T22:35:04Z

Hey @GTrunSec

Thanks for the PR! I like the simplification you made with the start up file.

A couple curious questions and one comment about an upcoming PR.

We are merging New UI (nixos modules based) #376 next week and it is going to change a lot of code. Could you rebase off that PR and make the necessary updates. I'm also happy to do it if you would like.
Is there some difference between julia and julia-bin? No problem switching. Just don't know.
What are you using the passthru for?

GTrunSec · 2023-01-26T23:13:14Z

Is there some difference between julia and julia-bin? No problem switching. Just don't know.

The difference is that binary source or building julia from the source with(nixpkgs prefer).

What are you using the passthru for?

It is convenient and important for us to reproduce the path(~/.local/jupyter/kernels*) of the kernels in the overall environment. You know most tools are based on that two values for getting kernel info.(jupyter kernelspec list --json or from $HOME/.local/jupyter kernels directly).

…y source

make sure we can import nixpkgs directrly example = { nixpkgs = import inputs.nixpkgs.path { config = {}; system = "x86_64-linux" }; # or nixpkgs = inputs.nixpks; }

GTrunSec · 2023-02-02T19:03:53Z

Fixes: #402
you can enable this feature with the module setting of config.jupyterlab.features = ["lsp"], more than one features like ["lsp" "jupytext"]

it allows us to link the kernelPaths, for solving some tools getting the kernelInfo only from ~/.local/jupyter/kernles or another place

GTrunSec · 2023-02-03T01:53:40Z

Oh, we got Julia-LSP working as well.

allows to spcific a languageServer package

GTrunSec · 2023-02-03T03:43:36Z

now, we can use the following code to specify a languageServer package or env.

    config = {
      jupyterlab = {
        extensions = {
          features = ["lsp" "jupytext"];
          languageServers = {
            python = ps: ps.python-lsp-server;
          };
        };
        jupyterlabEnvArgs.extraPackages = ps: ([] ++ ps.python-lsp-server.passthru.optional-dependencies.all);
      };
}

GTrunSec · 2023-02-03T18:25:15Z

@jamesdbrock I had a problem with haskell-language-server when I was trying to setup the lsp support.
The output was:

             , ghcide-type-lenses
             , ghcide-code-actions-imports-exports
             , ghcide-hover-and-symbols
             , eval
             , gadt
             , fourmolu
             , callHierarchy
             , stylish-haskell
             , ghcide-code-actions-type-signatures
             , ghcide-code-actions-bindings
             , moduleName
             , ormolu
             , ghcide-core
             , explicit-fixity ]
2023-02-03T18:22:53.958582Z | Info | Starting server
2023-02-03T18:22:53.965274Z | Info | Started LSP server in 0.01s
2023-02-03T18:22:54.008607Z | Info | Registering IDE configuration: IdeConfiguration {workspaceFolders = fromList [NormalizedUri (-7920826821002028544) "file:///home/guangtao/ghq/github.com/GTrunSec/DeSci/.virtual_documents"], clientSettings = hashed Nothing}
2023-02-03T18:22:54.485661Z | Warning | No plugin enabled for STextDocumentDidOpen
2023-02-03T18:22:54.490097Z | Warning | No plugin enabled for STextDocumentDidChange
2023-02-03T18:22:54.498037Z | Warning | No plugin enabled for STextDocumentDidChange
2023-02-03T18:22:54.502784Z | Warning | No plugin enabled for STextDocumentDidChange

So, do I need some specifically setting for hls? that would be enabled the completion and code highlight?

          languageServers = {
            python = ps: ps.python-lsp-server;
            haskell = nixpkgs.haskellPackages.ghcWithPackages (ghcPkgs:
              with ghcPkgs; [
                haskell-language-server
                hlint
                ghcide
              ]);
          };

thanks

jamesdbrock · 2023-02-04T11:41:04Z

@jamesdbrock I had a problem with haskell-language-server when I was trying to setup the lsp support. So, do I need some specifically setting for hls? that would be enabled the completion and code highlight?

Hi @GTrunSec , nice to hear from you. I love what you're trying to do here. Maybe you're asking my advice because I tried to get jupyter-lsp working with IHaskell once? jupyter-lsp/jupyterlab-lsp#313 I don't have any advice for you here, sorry. But you have my moral support! ❤️

GTrunSec · 2023-02-04T18:50:21Z

@jamesdbrock thanks for your response. I should open an issue on the upstream.

djacu · 2023-02-06T19:28:26Z

Hey @GTrunSec

Really awesome work here! Thanks for putting in all this effort.

I hate to ask but could you split this PR up? It looks like 3 or 4 PRs:

passthru
julia-bin -> julia
legacyPackages -> nixpkgs via module types
LSP

I was working primarily on https://github.com/nickel-lang/nickel-nix/ last week so I wasn't able to review anything
But I am back 50% on jupyenv so I can review things a lot quicker going forward.

GTrunSec · 2023-02-14T22:09:07Z

@thomasjm I see that you have been successfully running hls in codedownio(awesome project). Maybe you could give me some ideas for my current problem with haskell-language-server in jupyterlab-lsp. By the way, if you don't mind, I can attempt codedownio-desktop as an extra option to replace jupyterlab.
thanks

thomasjm · 2023-02-15T09:56:19Z

Hi @GTrunSec -- running HLS against Haskell notebooks is quite tricky, because IHaskell accepts top-level statements and stuff that HLS won't parse. I have a solution in progress but it's not quite ready to publish yet. I'm not familiar with jupyterlab-lsp but it looks a bit like a problem where you're trying to use a .ipynb extension and HLS doesn't like it because it only knows about .hs.

As soon as CodeDown Desktop is ready as a Jupyterlab alternative I'll let you know :)

GTrunSec · 2023-02-17T23:14:02Z

@thomasjm thanks, I see.

As soon as CodeDown Desktop is ready as a Jupyterlab alternative I'll let you know :)

Nice, looking forward to it. I also have an excellent MLOps solution for that.

GTrunSec requested review from k1nkreet and djacu as code owners January 24, 2023 16:54

GTrunSec marked this pull request as draft January 24, 2023 16:54

GTrunSec marked this pull request as ready for review January 24, 2023 17:36

juliaKenrel: refactor startupFile, use nixpkgs.julia instrad of binar…

267bcac

…y source

GTrunSec force-pushed the dev branch from fc2750f to 15e305f Compare February 2, 2023 16:25

modules: changes config.nixpkgs.legacyPackages to config.nixpkgs

618fb62

make sure we can import nixpkgs directrly example = { nixpkgs = import inputs.nixpkgs.path { config = {}; system = "x86_64-linux" }; # or nixpkgs = inputs.nixpks; }

GTrunSec force-pushed the dev branch from 0d8edc8 to 618fb62 Compare February 2, 2023 18:24

GTrunSec added 3 commits February 2, 2023 13:27

refactor: add jupyterlabEnvArgs option

23975bb

imp: add feature option for the jupyterlab extensions

6547edc

imp: add passthru kernels

ad4e0fd

it allows us to link the kernelPaths, for solving some tools getting the kernelInfo only from ~/.local/jupyter/kernles or another place

imp: add julia.option for juliaKernel module

9421ef9

GTrunSec force-pushed the dev branch from 7b1ad52 to 9421ef9 Compare February 3, 2023 02:02

imp: add extensions.languageServers options.

5029ae6

allows to spcific a languageServer package

GTrunSec mentioned this pull request Feb 3, 2023

[Feature]: LSP #402

Open

languageServe: fix haskell type

fc1128d

GTrunSec force-pushed the dev branch 2 times, most recently from e28478f to 670556f Compare February 4, 2023 16:13

jupyterlab: add notebookConfig option

c96f78e

GTrunSec force-pushed the dev branch from 670556f to c96f78e Compare February 4, 2023 17:39

example: add jupytext

1f1533a

GTrunSec force-pushed the dev branch 2 times, most recently from bdd3326 to 1f1533a Compare February 4, 2023 21:23

GTrunSec added 5 commits February 4, 2023 13:56

imp: use notebookConfig to set jupyter_notebook_config.json

e9d058e

imp: disable native_kernel Python 3

9ba09a7

fix: change moduleArgs's pkgs to config.nixpkgs

11d4aa2

Temapltes: add julia2nix and fixes args.config.julia

bc01e27

imp: exposes the mkJupyterlabEval to lib

3512564

This was referenced Feb 7, 2023

Improvement/switch julia bin for julia #423

Merged

feature/add-kernel-passthru #424

Merged

GTrunSec closed this Feb 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Develop changes #419

Develop changes #419

GTrunSec commented Jan 24, 2023

netlify bot commented Jan 24, 2023 •

edited

Loading

djacu commented Jan 26, 2023

GTrunSec commented Jan 26, 2023 •

edited

Loading

GTrunSec commented Feb 2, 2023 •

edited

Loading

GTrunSec commented Feb 3, 2023

GTrunSec commented Feb 3, 2023

GTrunSec commented Feb 3, 2023 •

edited

Loading

jamesdbrock commented Feb 4, 2023

GTrunSec commented Feb 4, 2023

djacu commented Feb 6, 2023

GTrunSec commented Feb 14, 2023 •

edited

Loading

thomasjm commented Feb 15, 2023

GTrunSec commented Feb 17, 2023

Develop changes #419

Develop changes #419

Conversation

GTrunSec commented Jan 24, 2023

netlify bot commented Jan 24, 2023 • edited Loading

✅ Deploy Preview for tweag-jupyterwith ready!

djacu commented Jan 26, 2023

GTrunSec commented Jan 26, 2023 • edited Loading

GTrunSec commented Feb 2, 2023 • edited Loading

GTrunSec commented Feb 3, 2023

GTrunSec commented Feb 3, 2023

GTrunSec commented Feb 3, 2023 • edited Loading

jamesdbrock commented Feb 4, 2023

GTrunSec commented Feb 4, 2023

djacu commented Feb 6, 2023

GTrunSec commented Feb 14, 2023 • edited Loading

thomasjm commented Feb 15, 2023

GTrunSec commented Feb 17, 2023

netlify bot commented Jan 24, 2023 •

edited

Loading

GTrunSec commented Jan 26, 2023 •

edited

Loading

GTrunSec commented Feb 2, 2023 •

edited

Loading

GTrunSec commented Feb 3, 2023 •

edited

Loading

GTrunSec commented Feb 14, 2023 •

edited

Loading