Allow making the cabal builds totally silent #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aherrmann
reviewed
Jan 7, 2020
haskell/private/cabal_wrapper.py.tpl
Outdated
Comment on lines
44
to
45
| print(err.stdout.decode()) | ||
| print(err.stderr.decode(), file=sys.stderr) |
There was a problem hiding this comment.
I think you can avoid the decode with sys.std(out|err).buffer.write.
There was a problem hiding this comment.
Oh thanks, didn't know that. I'll try this
There was a problem hiding this comment.
Nice, that works indeed.
Comment on lines
+977
to
+982
| "verbose": attr.bool( | ||
| default = False, | ||
| doc = "Whether to show the output of the build", | ||
| ), |
There was a problem hiding this comment.
This needs to be forwarded to the generated calls to haskell_cabal_library to have any effect.
There was a problem hiding this comment.
Indeed, just noticed that. Should be good now
aherrmann
approved these changes
Jan 7, 2020
haskell/private/cabal_wrapper.py.tpl
Outdated
Comment on lines
46
to
47
| # print(err.stdout.decode()) | ||
| # print(err.stderr.decode(), file=sys.stderr) |
Give an option in `cabal_haskell_library` and `stack_snapshot` to make the builds totally silent (except in case of failure). This is useful to enforce quietness even for build steps for which cabal can't enforce it (like `cabal configure` or `cabal haddock`)
…han true Co-Authored-By: Andreas Herrmann <andreas.herrmann@tweag.io>
mboes
force-pushed
the
quiet-cabal-builds
branch
from
476abb7
to
6bb8092
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give an option in
cabal_haskell_libraryandstack_snapshotto make the builds totally silent (except in case of failure).This is useful to enforce quietness even for build steps for which cabal can't enforce it (like
cabal configureorcabal haddock).I didn't add a test for it because I don't know how to test for the console output of a rule in bazel. If someone knows a way, I'd be happy to add a test for it.