-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for ghc 9.8.1 #2132
Merged
Merged
Support for ghc 9.8.1 #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function now emits a deprecation warning with ghc 9.8.1
This dependency is not needed since ghc 9.6
Folder names for packages now have an additional suffix which can be a hash, or `-inplace` See https://gitlab.haskell.org/ghc/ghc/-/issues/23788
see issue 2127
As with 9.6.2 proto-lens-protoc fails with an access violation error See issue 2131
ylecornec
force-pushed
the
ylecornec/ghc_9_8_1
branch
from
March 1, 2024 15:32
7e0d8ce
to
0f00663
Compare
avdv
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for ghc 9.8.1
In particular:
name-version-suffix
, where suffix which can be either a hash, or-inplace
: See https://gitlab.haskell.org/ghc/ghc/-/issues/23788. This only seems to affect thetest-haddock
test which was refactored a bit as these hashes vary between platforms.It may be possible to test targets that do not depend on these failing one but I did not try it yet. The targets failing are at least:
@stackage//:language-c
which is a dependency of thec2hs
toolchain//rule_info:rule_info_proto
//tests:test-haddock
is disabled because of Haddock 2.30 faillure in profiling mode #2127