-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement CLI changes #583
Commits on Aug 14, 2023
-
CLI Changes Sub-PR: New structure and parsing logic (#591)
* Add env feature to clap and cargo update * Dead Code: WIP CLI changes * Dead Code: CLI feature parity Although see clap-rs/clap#5020 * Note about not (yet) using infer_subcommands See clap-rs/clap#5021 * Use clap/wrap_help Although see clap-rs/clap#5022 * WIP: Strip out previous CLI argument parser setup [skip ci] * WIP: Normalise arguments for caller [skip ci] * Don't check for file-ness in the CLI argument parser * File and directory canonicalisation for the argument parser * Expose CLI types so they can be used downstream
Configuration menu - View commit details
-
Copy full SHA for 8dac896 - Browse repository at this point
Copy the full SHA 8dac896View commit details -
CLI Changes Sub-PR: Documentation (#592)
* Update CHANGELOG * Update README * Update script that checks that the README correlates with --help * Make README/CLI checking script a bit clearer * Updated usage with new collation modes * Documented configuration collation * Update example call sites to new CLI * Added a migration guide for the CLI changes to the CHANGELOG
Configuration menu - View commit details
-
Copy full SHA for 2588964 - Browse repository at this point
Copy the full SHA 2588964View commit details -
CLI Changes Sub-PR: Update supplementary tools (#594)
* Update TTY playground to use new interface * Update pre-commit hook to use new interface
Configuration menu - View commit details
-
Copy full SHA for fb8fc03 - Browse repository at this point
Copy the full SHA fb8fc03View commit details
Commits on Aug 15, 2023
-
CLI Changes Sub-PR: Configuration Subcommand (#593)
* Implement Display for Configuration: pretty-print TOML * Comment out old code, stub out new interface implementation * Additional collation mode * Some light refactoring * More refactoring... * Make the config collation independent of a specified config file As there are several potential sources of configuration, the collation mode is relevant whether a invocation-specific configuration file is specified, or not. This has the cheery consequence of sidestepping the issue described in clap-rs/clap#5020. * Add useful annotations to the computed TOML output * Refactor 'revise' collation mode from original * Remove unnecessary trailing \n from TOML output * Syntax tweak
Configuration menu - View commit details
-
Copy full SHA for b7303c2 - Browse repository at this point
Copy the full SHA b7303c2View commit details -
CLI Changes Sub-PR: TOML
merge
Collation (#596)* Add tests for TOML collation * Refactor: Update and use (non-differentiating) collation API * Got `merge` collation working Includes slight refactoring of Helix's TOML merging function, largely for my sake while I was trying to understand it! * Some sugar for your tea?
Configuration menu - View commit details
-
Copy full SHA for 3db6d95 - Browse repository at this point
Copy the full SHA 3db6d95View commit details
Commits on Aug 18, 2023
-
CLI Changes Sub-PR: Visualisation subcommand (#597)
* Note about not using infer_subcommands * --tolerate-parsing-errors doesn't make sense for visualisation * Separate out input source types so we can create a unified interface * Fallback to the given output path if canonicalisation fails Resolves #588 * We're going to need an InputFile, too * WIP: InputFile type * Correct blunder regarding --query Note that clap doesn't support (--foo [--bar] | --quux) groups very cleanly; it was a bit of a hack to get this to work, with the result being the error text being a bit off when an illegal combination is attempted. I've attempted to compensate for this by making the long help text quite explicit. Also updated clap, which contains the fix for clap-rs/clap#5022 * Missed change to README * Add note RE clap-rs/clap#4707 workaround * Machinery to unify inputs + downstream use to reimplement visualisation * Don't flatten-away errors * Don't open the input file until we need to read from it * Into InputFrom should be from &AtLeastOneInput * Add logging * Moar logging!1!!
Configuration menu - View commit details
-
Copy full SHA for f978b73 - Browse repository at this point
Copy the full SHA f978b73View commit details
Commits on Aug 24, 2023
-
CLI Changes Sub-PR: Formatting subcommand (#599)
* Beginnings of thread-safe language definition caching * Expose the raw values and implement Display * Thread-safe cache of language definitions * WIP: Formatting Formatting is now functional, but there remain implementation details to sort out. Bufferin, caching and error handling, in particular... * Add buffered reading and writing * Make the cache operational, if not suboptimal :( * Better error handling
Configuration menu - View commit details
-
Copy full SHA for 7bb02bc - Browse repository at this point
Copy the full SHA 7bb02bcView commit details
Commits on Aug 25, 2023
-
CLI Changes Sub-PR: Integration tests (#601)
* topiary fmt tests * Fix test task in CI workflow * Try increasing web test timeout to 30s * Make sure GNU sed is available, even on macOS * CLI tests for visualisation * CLI test for configuration output
Configuration menu - View commit details
-
Copy full SHA for ae9e80d - Browse repository at this point
Copy the full SHA ae9e80dView commit details -
Expose the logging level via the command line (#607)
* Expose logging verbosity through CLI flag * Updated documentation
Configuration menu - View commit details
-
Copy full SHA for 9d8d27f - Browse repository at this point
Copy the full SHA 9d8d27fView commit details -
Fix language definition cache locking (#608)
* Lock the cache with Tokio's Mutex * Use the entry API as it's a bit cleaner * Remove FIXME comment * Initialise the logger as early as possible
Configuration menu - View commit details
-
Copy full SHA for d9b4b3d - Browse repository at this point
Copy the full SHA d9b4b3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a278d8 - Browse repository at this point
Copy the full SHA 0a278d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d88566 - Browse repository at this point
Copy the full SHA 9d88566View commit details
Commits on Aug 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2401de2 - Browse repository at this point
Copy the full SHA 2401de2View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd253c9 - Browse repository at this point
Copy the full SHA dd253c9View commit details
Commits on Sep 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 29bdebe - Browse repository at this point
Copy the full SHA 29bdebeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 613a243 - Browse repository at this point
Copy the full SHA 613a243View commit details -
Configuration menu - View commit details
-
Copy full SHA for c478d5a - Browse repository at this point
Copy the full SHA c478d5aView commit details
Commits on Sep 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 37cbcf9 - Browse repository at this point
Copy the full SHA 37cbcf9View commit details -
Configuration menu - View commit details
-
Copy full SHA for aae572d - Browse repository at this point
Copy the full SHA aae572dView commit details -
Configuration menu - View commit details
-
Copy full SHA for da0f64a - Browse repository at this point
Copy the full SHA da0f64aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d4563b - Browse repository at this point
Copy the full SHA 8d4563bView commit details -
Simplify pre-commit-hook definition
NOTE: nixfmt also had its way with the source; hence the unrelated diffs
Configuration menu - View commit details
-
Copy full SHA for 21efefb - Browse repository at this point
Copy the full SHA 21efefbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5510406 - Browse repository at this point
Copy the full SHA 5510406View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0066227 - Browse repository at this point
Copy the full SHA 0066227View commit details