fix(popover): remove popovercontainer Box wrapper #2011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e852cb9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
Status: Do Not Merge
|
Size Change: -21 B (0%) Total Size: 449 kB
ℹ️ View Unchanged
|
TheSisb
force-pushed
the
popover/remove-container-box
branch
from
2b31ea2 to
c1f3264
Compare
TheSisb
force-pushed
the
popover/remove-container-box
branch
from
c1f3264 to
804c18f
Compare
|
✔️ Deploy Preview for paste-docs ready! 🔨 Explore the source changes: c1f3264 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-docs/deploys/61855adc6334f30007a8e8cb 😎 Browse the preview: https://deploy-preview-2011--paste-docs.netlify.app |
|
✔️ Deploy Preview for paste-theme-designer ready! 🔨 Explore the source changes: e852cb9 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-theme-designer/deploys/61895f4d9d710200078d4289 😎 Browse the preview: https://deploy-preview-2011--paste-theme-designer.netlify.app |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e852cb9:
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
nkrantz
approved these changes
Nov 5, 2021
| const popover = state || useNonModalDialogPrimitiveState({gutter, modal: true, placement, ...initialState}); | ||
| return ( | ||
| <PopoverContext.Provider value={popover}> | ||
| <Box ref={ref}>{children}</Box> |
There was a problem hiding this comment.
What does removing the ref here do exactly?
There was a problem hiding this comment.
All our components forward refs, so I think it was just doing what other components do. But this isn't a standard component, it's similar to Theme.Provider and is just a React Context.
Removing or adding ref would ordinarily be a breaking change, but since this isn't a standard component and ref here is arguably useless, and since reporting shows no one is passing ref to this --- it should be harmless to remove and mark as a minor change.
shleewhite
approved these changes
Nov 8, 2021
SiTaggart
approved these changes
Nov 8, 2021
|
✔️ Deploy Preview for paste-docs ready! 🔨 Explore the source changes: e852cb9 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-docs/deploys/61895f4d6705d00008b62b0a 😎 Browse the preview: https://deploy-preview-2011--paste-docs.netlify.app |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1978 and #2006 and #1870
Removes the wrapping Box in PopoverContainer. PopoverContainer is simply a context provider, like Theme.Provider, and that wrapping Box just added styling issues.