test: Add missing test coverage for regional endpoint processing deprecation warnings #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Added three test cases to verify deprecation warnings and edge cases: - Warning when both edge and region are set - Warning when region maps to edge - No edge set for unmapped regions Note: Secret scanner may flag lines 127,131 as false positives - these are pre-existing test fixtures not modified in this commit. Co-authored-by: manisha1997 <28821901+manisha1997@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on regional endpoint processing PR
test: Add missing test coverage for regional endpoint processing deprecation warnings
Dec 1, 2025
manisha1997
approved these changes
Dec 1, 2025
|
manisha1997
added a commit
that referenced
this pull request
Dec 2, 2025
* fix: Regional Endpoint Processing * fix: Regional Endpoint Processing * Update src/base-commands/twilio-client-command.js Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/base-commands/twilio-client-command.js Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/base-commands/twilio-client-command.js Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * test: Add missing test coverage for regional endpoint processing deprecation warnings (#297) * Initial plan * Add test coverage for regional endpoint processing Added three test cases to verify deprecation warnings and edge cases: - Warning when both edge and region are set - Warning when region maps to edge - No edge set for unmapped regions Note: Secret scanner may flag lines 127,131 as false positives - these are pre-existing test fixtures not modified in this commit. Co-authored-by: manisha1997 <28821901+manisha1997@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: manisha1997 <28821901+manisha1997@users.noreply.github.com> * fix: Regional Endpoint Processing --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: manisha1997 <28821901+manisha1997@users.noreply.github.com>
twilio-dx
pushed a commit
that referenced
this pull request
Dec 8, 2025
### [8.2.4](8.2.3...8.2.4) (2025-12-08) ### Library - Fixes * Add edge parameter support for regional authentication ([#298](#298)) ([9f023f4](9f023f4)) * Regional Endpoint Processing ([#296](#296)) ([b3786ca](b3786ca)), closes [#297](#297) ### Library - Chores * add npm token for semantic-release authentication ([e13b03c](e13b03c)) * Add trusted publisher ([#299](#299)) ([a544aea](a544aea)) * remove registry url ([6a1c488](6a1c488))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses incomplete test coverage for regional endpoint processing logic introduced in PR #296. Three scenarios were untested:
Changes
configEdgeandenvRegionare both defined, confirming edge takes precedenceREGION_EDGE_MAPand edge is auto-set (e.g.,ie1→dublin)REGION_EDGE_MAPAll tests require
-l debugflag to capture stderr warnings. Test assertions must accesstwilioApiClientbefore checking stderr to trigger lazy client initialization.Checklist
Warning
GitHub's Secret Scanning detected potential secrets in the added content. We attempted to remediate the issue by updating the code or redacting.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.