fix: Update release feature branch

[ravali-rimmalapudi]

Fixes

Updating the release feature branch
Test Gist: Link

Checklist

• I acknowledge that all my contributions will be made under the project's license
• I have made a material change to the repo (functionality, testing, spelling, grammar)
• I have read the Contribution Guidelines and my PR follows them
• I have titled the PR appropriately
• I have updated my branch with the main branch
• I have added tests that prove my fix is effective or that my feature works
• I have added the necessary documentation about the functionality in the appropriate .md file
• I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

[onuzbee]

Were these commits cherry-picked manually? Any idea on how to verify for any commit we might have missed post this merge?

[kridai]

Were these commits cherry-picked manually? Any idea on how to verify for any commit we might have missed post this merge?

Ravali had these commits in her forked repo for release-feature-branch. We did try and check the commits of the closed PRs by each member for release feature branch to be present here. We can all do the same to verify.

[ravali-rimmalapudi]

Were these commits cherry-picked manually? Any idea on how to verify for any commit we might have missed post this merge?

Not cherry-picked manually, These commits are from my forked repo. I didn't pulled the latest changes from twilio-cli release-feature-branch. You can test it locally by checking out to my forked repo release-feature-branch and point cli-core to twilio-cli-core release-feature-branch.

[shrutiburman]

Okay. Do you have any possible root causes for this? It'd help in narrowing down the manual effort of comparing. If not, I feel we should also verify commits before June, just to be sure.

[ravali-rimmalapudi]

Okay. Do you have any possible root causes for this? It'd help in narrowing down the manual effort of comparing. If not, I feel we should also verify commits before June, just to be sure.

I wasn't sure exact root cause suspecting because of merging of main to release-feature-branch might not be proper. We created release-feature-branch after we joined only, so we tested the closed PR's by all our teammates and verified it. You can also verify it from your side.

[onuzbee]

I see UTs failing. Is it a similar case for twilio-cli-core that commits are missing there?
I see twilio-cli-core being pointed to the main release, which might hint some missing commits that pinned to the -rc tag for cli-core (Which is causing these failures).

Example:

commands
       profiles
         remove
           run profiles:remove with the last configured profile in keytar and delete all keys:
     TypeError: Cannot read properties of undefined (reading 'removeCallback')
      at Object.finally (node_modules/@twilio/cli-test/src/index.js:65:27)
      at Context.run (node_modules/fancy-test/lib/base.js:79:36)

[ravali-rimmalapudi]

I see UTs failing. Is it a similar case for twilio-cli-core that commits are missing there? I see twilio-cli-core being pointed to the main release, which might hint some missing commits that pinned to the -rc tag for cli-core (Which is causing these failures).

Example:

commands
       profiles
         remove
           run profiles:remove with the last configured profile in keytar and delete all keys:
     TypeError: Cannot read properties of undefined (reading 'removeCallback')
      at Object.finally (node_modules/@twilio/cli-test/src/index.js:65:27)
      at Context.run (node_modules/fancy-test/lib/base.js:79:36)

As far as my check in twilio-cli-core, commits are there. Can you also verify once. And regarding the test failure it is because of cli-core is pointing to main tag, I ran the tests locally by pointing to release-feature-branch and posted the gist link in the PR.
Currently in the last release candidate release cli-core is not released to npm so we updated it main release while resolving the conflicts. After today's cli-core release, I will update it with correct version and release cli.

[ravali-rimmalapudi]

I see UTs failing. Is it a similar case for twilio-cli-core that commits are missing there? I see twilio-cli-core being pointed to the main release, which might hint some missing commits that pinned to the -rc tag for cli-core (Which is causing these failures).
Example:

commands
       profiles
         remove
           run profiles:remove with the last configured profile in keytar and delete all keys:
     TypeError: Cannot read properties of undefined (reading 'removeCallback')
      at Object.finally (node_modules/@twilio/cli-test/src/index.js:65:27)
      at Context.run (node_modules/fancy-test/lib/base.js:79:36)

As far as my check in twilio-cli-core, commits are there. Can you also verify once. And regarding the test failure it is because of cli-core is pointing to main tag, I ran the tests locally by pointing to release-feature-branch and posted the gist link in the PR. Currently in the last release candidate release cli-core is not released to npm so we updated it main release while resolving the conflicts. After today's cli-core release, I will update it with correct version and release cli.

I see UTs failing. Is it a similar case for twilio-cli-core that commits are missing there? I see twilio-cli-core being pointed to the main release, which might hint some missing commits that pinned to the -rc tag for cli-core (Which is causing these failures).
Example:

commands
       profiles
         remove
           run profiles:remove with the last configured profile in keytar and delete all keys:
     TypeError: Cannot read properties of undefined (reading 'removeCallback')
      at Object.finally (node_modules/@twilio/cli-test/src/index.js:65:27)
      at Context.run (node_modules/fancy-test/lib/base.js:79:36)

As far as my check in twilio-cli-core, commits are there. Can you also verify once. And regarding the test failure it is because of cli-core is pointing to main tag, I ran the tests locally by pointing to release-feature-branch and posted the gist link in the PR. Currently in the last release candidate release cli-core is not released to npm so we updated it main release while resolving the conflicts. After today's cli-core release, I will update it with correct version and release cli.

Please review the merge commit. If you think any changes we missed/overwritten while resolving the conflicts, Please let us know.

[onuzbee]

👍🏻