chore: Store API Keys in Config File #259

onuzbee · 2021-06-08T11:48:36Z

Fixes

Closes : DI-1350
Dependent PR: Link

Changes in profiles:create to add api keys in config file.

Testing Gist : Link

Checklist

I acknowledge that all my contributions will be made under the project's license
I have made a material change to the repo (functionality, testing, spelling, grammar)
I have read the Contribution Guidelines and my PR follows them
I have titled the PR appropriately
I have updated my branch with the main branch
I have added tests that prove my fix is effective or that my feature works
I have added the necessary documentation about the functionality in the appropriate .md file
I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

onuzbee · 2021-06-08T11:52:32Z

src/commands/profiles/create.js

@@ -241,14 +231,11 @@ class ProfilesCreate extends BaseCommand {
      throw new TwilioCliError('Could not create an API Key.');
    }

-    this.userConfig.addProfile(this.profileId, this.accountSid, this.region);
-    await this.secureStorage.saveCredentials(this.profileId, apiKey.sid, apiKey.secret);


[Self] Still keeping saveCredentials method in secureStorage intact, and will be removed later on with complete migration.

ravali-rimmalapudi · 2021-06-21T06:28:35Z

src/commands/profiles/create.js

@@ -30,9 +23,6 @@ class ProfilesCreate extends BaseCommand {
  async run() {
    await super.run();

-    // Eagerly load up the credential store. No need to proceed if this fails.
-    await this.secureStorage.loadKeytar();


Any idea why we used to do this previously? Is it not effect the case where profiles are in both keytar and config file?

Previously since all keys were in keytar, it made sense to load this early on and then read the credentials, but now, since we are storing in file by default, we shouldn't do this eager loading. They will be loaded from keytar only when necessary.

ravali-rimmalapudi

Looks Good.

ravali-rimmalapudi · 2021-06-21T09:32:04Z

test/commands/profiles/list.test.js

-          expect(ctx.stdout.match(/true/g)).to.have.length(1);
-          expect(ctx.stderr).to.equal('');
-        });
+      /*


Can we add TODO for these cases also, so that we will not miss tracking.

* chore: Refactor profiles usage to projects (#257) * chore: Store API Keys in Config File (#259) * Save to config and not keytar * Remove secure storage references * Remove keytar load * Remove unnecessary ref to secureStorage * Correct logging * Remove dependent test failures * Add todos * chore: CLI Profile Remove - Check and Use config file before checking system keychain. (#262) * chore: CLI Profile Update - Using config file instead of the system keychain (#264) * chore: CLI Profile Update - Using config file instead of the system keychain * Added the test cases. * Addressed the review comments * Added the missing alignment. * Addressed the review comments * chore: Update profiles list (#265) * chore: Update profiles list * Addressed the comments * chore: Add profiles:port (#266) * Add profiles:port * Eslint fix * Minor edit * update test * Address review comments * Change nomenclature from porting profiles to porting keys * add space * chore: Throw alert when active profile is not set (#267) * Fetching profile by order if active profile is not set 1. Added the warning when active profile is NULL and no environment variable is set in case of profile create/update. 2. Added/updated the corresponding test cases. * Addressed the comments * chore: change post install messaging behaviour (#269) * feat: Added twilio config to list/set edge configuration (#270) * feat: Added twilio config to list/set edge configuration * Added the missing changes * Addressed the review comments. * Updated the missing messages * Updated the review comments. * Moved the common code functionality to utility. * Added the missing change. * Minor refactoring in the getFromEnvironment method. * chore - Updated package.json to point to cli-core release candidate and cli-test new release (#273) * [chore] - Updating package.json to point to cli-core release candidate and cli-test new release * Removed the cli-test version upgrade. * Added the shortform * Updated the cli-core version. * fix: Update release-feature-branch with main (#275) * update slack token * feat: add assets plugin to available plugins (#261) * [Librarian] Regenerated @ 8ec9e610ad617fae257b54113f6d7fa08c457a87 * Release 2.25.0 * chore: updating plugin-help version (#268) Co-authored-by: kridai <kgoswami@twilio.com> * [Librarian] Regenerated @ 7bffdec2c05f6a34b94cebd095be5b1b30705f5d * Release 2.26.0 * [Librarian] Regenerated @ 54ad9271a294331f8d036e4a3fc173bb98ecdb82 * Release 2.27.0 Co-authored-by: Elmer Thomas <ethomas@twilio.com> Co-authored-by: Phil Nash <pnash@twilio.com> Co-authored-by: Twilio <team_interfaces+github@twilio.com> Co-authored-by: kridai <kridaigoswami@gmail.com> Co-authored-by: kridai <kgoswami@twilio.com> * Updated the cli-core package version with latest. * [Librarian] Regenerated @ 54ad9271a294331f8d036e4a3fc173bb98ecdb82 * Release 2.27.1-rc * chore: Fix autocomplete bugs (#274) Co-authored-by: Shamant Raghav <sraghav@twilio.com> * feat: add new flag support for config commands to force profile input flag (#272) * feat: add new flag support require-profile-input for config commands * updated tests for config set and list * refactor logic for config set * nit, adding comment * changes per review comment, updating the parsing login for config list command * feature: Twilio update (#278) * SR: Oclif Update changes * SR: adding message to alert about the update * minor change Co-authored-by: Shamant Raghav <sraghav@twilio.com> Co-authored-by: Anuj Badhwar <abadhwar@twilio.com> Co-authored-by: Elmer Thomas <ethomas@twilio.com> Co-authored-by: Phil Nash <pnash@twilio.com> Co-authored-by: Twilio <team_interfaces+github@twilio.com> Co-authored-by: kridai <kridaigoswami@gmail.com> Co-authored-by: kridai <kgoswami@twilio.com> Co-authored-by: shamantraghav <87780745+shamantraghav@users.noreply.github.com> Co-authored-by: Shamant Raghav <sraghav@twilio.com>

## [2.33.0-rc.2](2.33.0-rc.1...2.33.0-rc.2) (2021-11-12) ### Library - Fixes * Hardcoding the name of the first part of the package ([#327](#327)) ([67b44cb](67b44cb)), closes [#313](#313) [#312](#312) [#318](#318) [#289](#289) [#287](#287) [#284](#284) [#286](#286) [#285](#285) [#294](#294) [#295](#295) [#293](#293) [#297](#297) [#298](#298) [#301](#301) [#304](#304) [#310](#310) [#306](#306) [#315](#315) [#316](#316) [#289](#289) [#281](#281) [#298](#298) [#287](#287) [#284](#284) [#304](#304) [#312](#312) [#286](#286) [#285](#285) [#283](#283) [#294](#294) [#285](#285) [#279](#279) [#301](#301) [#280](#280) [#313](#313) [#295](#295) [#293](#293) [#310](#310) [#318](#318) [#297](#297) [#306](#306) [#315](#315) [#316](#316) [#321](#321) * Update release feature branch ([#330](#330)) ([5878348](5878348)), closes [#257](#257) [#259](#259) [#262](#262) [#264](#264) [#265](#265) [#266](#266) [#267](#267) [#269](#269) [#270](#270) [#273](#273) [#275](#275) [#261](#261) [#268](#268) [#274](#274) [#272](#272) [#278](#278) * Updated cli-core version with the latest rc tag. ([abe116e](abe116e))

Anuj added 5 commits June 7, 2021 15:31

Save to config and not keytar

a14f583

Remove secure storage references

8b43462

Remove keytar load

6f0db80

Remove unnecessary ref to secureStorage

c9b9dc6

Correct logging

d2b4561

onuzbee mentioned this pull request Jun 8, 2021

chore: Store API Keys in Config File twilio/twilio-cli-core#124

Merged

8 tasks

onuzbee requested review from Sindhura3, ravali-rimmalapudi and childish-sambino June 8, 2021 11:50

onuzbee commented Jun 8, 2021

View reviewed changes

childish-sambino previously approved these changes Jun 8, 2021

View reviewed changes

Sindhura3 previously approved these changes Jun 15, 2021

View reviewed changes

Remove dependent test failures

e765ef4

onuzbee dismissed stale reviews from Sindhura3 and childish-sambino via e765ef4 June 16, 2021 14:35

ravali-rimmalapudi reviewed Jun 21, 2021

View reviewed changes

ravali-rimmalapudi previously approved these changes Jun 21, 2021

View reviewed changes

ravali-rimmalapudi reviewed Jun 21, 2021

View reviewed changes

Add todos

d7a4759

onuzbee dismissed ravali-rimmalapudi’s stale review via d7a4759 June 21, 2021 12:54

childish-sambino approved these changes Jun 21, 2021

View reviewed changes

Sindhura3 merged commit c679ed8 into release-feature-branch Jun 21, 2021

Sindhura3 deleted the dev-profiles-create branch June 21, 2021 14:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Store API Keys in Config File #259

chore: Store API Keys in Config File #259

onuzbee commented Jun 8, 2021 •

edited

Loading

onuzbee Jun 8, 2021

ravali-rimmalapudi Jun 21, 2021

Sindhura3 Jun 21, 2021

ravali-rimmalapudi Jun 21, 2021

ravali-rimmalapudi left a comment

ravali-rimmalapudi Jun 21, 2021 •

edited

Loading

onuzbee Jun 21, 2021

chore: Store API Keys in Config File #259

chore: Store API Keys in Config File #259

Conversation

onuzbee commented Jun 8, 2021 • edited Loading

Fixes

Checklist

onuzbee Jun 8, 2021

Choose a reason for hiding this comment

ravali-rimmalapudi Jun 21, 2021

Choose a reason for hiding this comment

Sindhura3 Jun 21, 2021

Choose a reason for hiding this comment

ravali-rimmalapudi Jun 21, 2021

Choose a reason for hiding this comment

ravali-rimmalapudi left a comment

Choose a reason for hiding this comment

ravali-rimmalapudi Jun 21, 2021 • edited Loading

Choose a reason for hiding this comment

onuzbee Jun 21, 2021

Choose a reason for hiding this comment

onuzbee commented Jun 8, 2021 •

edited

Loading

ravali-rimmalapudi Jun 21, 2021 •

edited

Loading