chore: Updated package.json to point to cli-core release candidate and cli-test new release #273

ravali-rimmalapudi · 2021-07-28T07:58:26Z

Fixes

Updated package.json to point to cli-core release candidate and cli-test new release

Checklist

I acknowledge that all my contributions will be made under the project's license
I have made a material change to the repo (functionality, testing, spelling, grammar)
I have read the Contribution Guidelines and my PR follows them
I have titled the PR appropriately
I have updated my branch with the main branch
I have added tests that prove my fix is effective or that my feature works
I have added the necessary documentation about the functionality in the appropriate .md file
I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

…e and cli-test new release

ravali-rimmalapudi · 2021-07-28T08:06:25Z

package.json

@@ -43,7 +43,7 @@
    "@oclif/plugin-plugins": "^1.8.3",
    "@oclif/plugin-warn-if-update-available": "^1.7.0",
    "@sendgrid/mail": "^7.2.1",
-    "@twilio/cli-core": "^5.9.1",
+    "@twilio/cli-core": "https://github.com/twilio/twilio-cli-core.git#5.26.1-rc",


As per the docs, If the tag does not exist in the registry data for the package, it will fail. So added tag from github directly.
Please suggest if we have any other better way to do this.

Makes sense to me, since it's not published to npm yet, it should be fine to go via github tags route untill the changes are pushed to main.

[Q] This might not work with the Librarian logic for the PR you added for bumping up the version right? Or does it pick up the parsed tag version itself while bumping up?

Currently librarian is picking the version from changes.md not from package.json. In librarian I have added the change to bump the version as -rc if the branch is not main but not yet pushed.

nit - Might consider replacing with a shorter syntax:

"@twilio/cli-core": "twilio/twilio-cli-core#5.26.1-rc",

onuzbee · 2021-07-28T09:18:58Z

package.json

@@ -43,7 +43,7 @@
    "@oclif/plugin-plugins": "^1.8.3",
    "@oclif/plugin-warn-if-update-available": "^1.7.0",
    "@sendgrid/mail": "^7.2.1",
-    "@twilio/cli-core": "^5.9.1",
+    "@twilio/cli-core": "https://github.com/twilio/twilio-cli-core.git#5.26.1-rc",


Makes sense to me, since it's not published to npm yet, it should be fine to go via github tags route untill the changes are pushed to main.

[Q] This might not work with the Librarian logic for the PR you added for bumping up the version right? Or does it pick up the parsed tag version itself while bumping up?

onuzbee · 2021-07-28T09:19:03Z

package.json

@@ -55,7 +55,7 @@
  "devDependencies": {
    "@oclif/dev-cli": "^1.22.2",
    "@oclif/test": "^1.2.6",
-    "@twilio/cli-test": "^2.1.0",
+    "@twilio/cli-test": "^2.1.2",


This bump shouldn't be needed. ^ should handle all the future minor/patch version upgrades with next installation.

Yes, Thanks.

Sindhura3 · 2021-07-28T17:39:01Z

@ravali-rimmalapudi the CI build seems to have failed due to this change because it is not able to read from the remote repo directly. May need an update there

onuzbee

I see this in travis:

npm install --no-optional
npm ERR! code 128
npm ERR! command failed
npm ERR! command git --no-replace-objects ls-remote ssh://git@github.com/twilio/twilio-cli-core.git
npm ERR! command-line line 0: unsupported option "accept-new".
npm ERR! fatal: Could not read from remote repository.
npm ERR! 
npm ERR! Please make sure you have the correct access rights
npm ERR! and the repository exists.

I'm assuming this should be resolved post a non-production release for tag 5.26.1-rc over github? Let's rerun the travis build post release before merging just to be sure?

sonarcloud · 2021-07-28T18:24:44Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

ravali-rimmalapudi · 2021-07-28T18:27:33Z

@ravali-rimmalapudi the CI build seems to have failed due to this change because it is not able to read from the remote repo directly. May need an update there

yes, as @onuzbee mentioned it is because of the tag 5.26.1-rc is not yet released. Once the release is done this issue should be resolved.

* chore: Refactor profiles usage to projects (#257) * chore: Store API Keys in Config File (#259) * Save to config and not keytar * Remove secure storage references * Remove keytar load * Remove unnecessary ref to secureStorage * Correct logging * Remove dependent test failures * Add todos * chore: CLI Profile Remove - Check and Use config file before checking system keychain. (#262) * chore: CLI Profile Update - Using config file instead of the system keychain (#264) * chore: CLI Profile Update - Using config file instead of the system keychain * Added the test cases. * Addressed the review comments * Added the missing alignment. * Addressed the review comments * chore: Update profiles list (#265) * chore: Update profiles list * Addressed the comments * chore: Add profiles:port (#266) * Add profiles:port * Eslint fix * Minor edit * update test * Address review comments * Change nomenclature from porting profiles to porting keys * add space * chore: Throw alert when active profile is not set (#267) * Fetching profile by order if active profile is not set 1. Added the warning when active profile is NULL and no environment variable is set in case of profile create/update. 2. Added/updated the corresponding test cases. * Addressed the comments * chore: change post install messaging behaviour (#269) * feat: Added twilio config to list/set edge configuration (#270) * feat: Added twilio config to list/set edge configuration * Added the missing changes * Addressed the review comments. * Updated the missing messages * Updated the review comments. * Moved the common code functionality to utility. * Added the missing change. * Minor refactoring in the getFromEnvironment method. * chore - Updated package.json to point to cli-core release candidate and cli-test new release (#273) * [chore] - Updating package.json to point to cli-core release candidate and cli-test new release * Removed the cli-test version upgrade. * Added the shortform * Updated the cli-core version. * fix: Update release-feature-branch with main (#275) * update slack token * feat: add assets plugin to available plugins (#261) * [Librarian] Regenerated @ 8ec9e610ad617fae257b54113f6d7fa08c457a87 * Release 2.25.0 * chore: updating plugin-help version (#268) Co-authored-by: kridai <kgoswami@twilio.com> * [Librarian] Regenerated @ 7bffdec2c05f6a34b94cebd095be5b1b30705f5d * Release 2.26.0 * [Librarian] Regenerated @ 54ad9271a294331f8d036e4a3fc173bb98ecdb82 * Release 2.27.0 Co-authored-by: Elmer Thomas <ethomas@twilio.com> Co-authored-by: Phil Nash <pnash@twilio.com> Co-authored-by: Twilio <team_interfaces+github@twilio.com> Co-authored-by: kridai <kridaigoswami@gmail.com> Co-authored-by: kridai <kgoswami@twilio.com> * Updated the cli-core package version with latest. * [Librarian] Regenerated @ 54ad9271a294331f8d036e4a3fc173bb98ecdb82 * Release 2.27.1-rc * chore: Fix autocomplete bugs (#274) Co-authored-by: Shamant Raghav <sraghav@twilio.com> * feat: add new flag support for config commands to force profile input flag (#272) * feat: add new flag support require-profile-input for config commands * updated tests for config set and list * refactor logic for config set * nit, adding comment * changes per review comment, updating the parsing login for config list command * feature: Twilio update (#278) * SR: Oclif Update changes * SR: adding message to alert about the update * minor change Co-authored-by: Shamant Raghav <sraghav@twilio.com> Co-authored-by: Anuj Badhwar <abadhwar@twilio.com> Co-authored-by: Elmer Thomas <ethomas@twilio.com> Co-authored-by: Phil Nash <pnash@twilio.com> Co-authored-by: Twilio <team_interfaces+github@twilio.com> Co-authored-by: kridai <kridaigoswami@gmail.com> Co-authored-by: kridai <kgoswami@twilio.com> Co-authored-by: shamantraghav <87780745+shamantraghav@users.noreply.github.com> Co-authored-by: Shamant Raghav <sraghav@twilio.com>

## [2.33.0-rc.2](2.33.0-rc.1...2.33.0-rc.2) (2021-11-12) ### Library - Fixes * Hardcoding the name of the first part of the package ([#327](#327)) ([67b44cb](67b44cb)), closes [#313](#313) [#312](#312) [#318](#318) [#289](#289) [#287](#287) [#284](#284) [#286](#286) [#285](#285) [#294](#294) [#295](#295) [#293](#293) [#297](#297) [#298](#298) [#301](#301) [#304](#304) [#310](#310) [#306](#306) [#315](#315) [#316](#316) [#289](#289) [#281](#281) [#298](#298) [#287](#287) [#284](#284) [#304](#304) [#312](#312) [#286](#286) [#285](#285) [#283](#283) [#294](#294) [#285](#285) [#279](#279) [#301](#301) [#280](#280) [#313](#313) [#295](#295) [#293](#293) [#310](#310) [#318](#318) [#297](#297) [#306](#306) [#315](#315) [#316](#316) [#321](#321) * Update release feature branch ([#330](#330)) ([5878348](5878348)), closes [#257](#257) [#259](#259) [#262](#262) [#264](#264) [#265](#265) [#266](#266) [#267](#267) [#269](#269) [#270](#270) [#273](#273) [#275](#275) [#261](#261) [#268](#268) [#274](#274) [#272](#272) [#278](#278) * Updated cli-core version with the latest rc tag. ([abe116e](abe116e))

[chore] - Updating package.json to point to cli-core release candidat…

29c3c26

…e and cli-test new release

ravali-rimmalapudi requested review from Sindhura3, onuzbee and childish-sambino July 28, 2021 07:58

ravali-rimmalapudi commented Jul 28, 2021

View reviewed changes

ravali-rimmalapudi requested review from kridai, sr010 and shrutiburman July 28, 2021 08:12

onuzbee reviewed Jul 28, 2021

View reviewed changes

Removed the cli-test version upgrade.

922138a

ravali-rimmalapudi changed the title ~~[chore] - Updated package.json to point to cli-core release candidate and cli-test new release~~ chore - Updated package.json to point to cli-core release candidate and cli-test new release Jul 28, 2021

onuzbee previously approved these changes Jul 28, 2021

View reviewed changes

Added the shortform

386a7d2

ravali-rimmalapudi dismissed onuzbee’s stale review via 386a7d2 July 28, 2021 18:24

Sindhura3 merged commit fe51073 into release-feature-branch Jul 28, 2021

Sindhura3 deleted the version_update branch July 28, 2021 19:40

ravali-rimmalapudi changed the title ~~chore - Updated package.json to point to cli-core release candidate and cli-test new release~~ chore: Updated package.json to point to cli-core release candidate and cli-test new release Jul 29, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Updated package.json to point to cli-core release candidate and cli-test new release #273

chore: Updated package.json to point to cli-core release candidate and cli-test new release #273

ravali-rimmalapudi commented Jul 28, 2021

ravali-rimmalapudi Jul 28, 2021

onuzbee Jul 28, 2021

ravali-rimmalapudi Jul 28, 2021

onuzbee Jul 28, 2021

onuzbee Jul 28, 2021

onuzbee Jul 28, 2021

ravali-rimmalapudi Jul 28, 2021

Sindhura3 commented Jul 28, 2021

onuzbee left a comment

sonarcloud bot commented Jul 28, 2021

ravali-rimmalapudi commented Jul 28, 2021

chore: Updated package.json to point to cli-core release candidate and cli-test new release #273

chore: Updated package.json to point to cli-core release candidate and cli-test new release #273

Conversation

ravali-rimmalapudi commented Jul 28, 2021

Fixes

Checklist

ravali-rimmalapudi Jul 28, 2021

Choose a reason for hiding this comment

onuzbee Jul 28, 2021

Choose a reason for hiding this comment

ravali-rimmalapudi Jul 28, 2021

Choose a reason for hiding this comment

onuzbee Jul 28, 2021

Choose a reason for hiding this comment

onuzbee Jul 28, 2021

Choose a reason for hiding this comment

onuzbee Jul 28, 2021

Choose a reason for hiding this comment

ravali-rimmalapudi Jul 28, 2021

Choose a reason for hiding this comment

Sindhura3 commented Jul 28, 2021

onuzbee left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Jul 28, 2021

ravali-rimmalapudi commented Jul 28, 2021