chore: Throw alert when active profile is not set #267

ravali-rimmalapudi · 2021-07-06T13:17:53Z

Fixes

Closes : DI-1479
Dependent PR: CLI-CORE, CLI-TEST

Changes in active profile: Throwing the alert when active profile is NULL and no environment variable is set in case of any command that requires API keys.

Testing Gist : Link

Checklist

I acknowledge that all my contributions will be made under the project's license
I have made a material change to the repo (functionality, testing, spelling, grammar)
I have read the Contribution Guidelines and my PR follows them
I have titled the PR appropriately
I have updated my branch with the main branch
I have added tests that prove my fix is effective or that my feature works
I have added the necessary documentation about the functionality in the appropriate .md file
I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

1. Added the warning when active profile is NULL and no environment variable is set in case of profile create/update. 2. Added/updated the corresponding test cases.

onuzbee · 2021-07-06T14:29:45Z

src/commands/profiles/list.js

@@ -16,7 +16,7 @@ class ProfilesList extends BaseCommand {
      this.userConfig.projects.unshift(strippedEnvProfile);
      this.userConfig.setActiveProfile(strippedEnvProfile.id);
    }
-    const profiles = this.userConfig.projects;
+    const profiles = this.userConfig.projects.slice(0);


Why's slicing needed? Might be interpreting it wrong, but isn't Array.slice(0) kinda equal to referencing the same? Or does it require deep-cloning?

I used slice to create a shallow copy. It requires shallow copy because getActiveProfile, uses the projects to return the active profile.

onuzbee · 2021-07-06T14:31:39Z

test/commands/profiles/remove.test.js

+            if (setActiveProfile) {
+              ctx.userConfig.setActiveProfile(setActiveProfile);
+            }


nit - Consider moving to a separate .do((ctx) => {}) blob?

onuzbee

👍🏻

* chore: Refactor profiles usage to projects (#257) * chore: Store API Keys in Config File (#259) * Save to config and not keytar * Remove secure storage references * Remove keytar load * Remove unnecessary ref to secureStorage * Correct logging * Remove dependent test failures * Add todos * chore: CLI Profile Remove - Check and Use config file before checking system keychain. (#262) * chore: CLI Profile Update - Using config file instead of the system keychain (#264) * chore: CLI Profile Update - Using config file instead of the system keychain * Added the test cases. * Addressed the review comments * Added the missing alignment. * Addressed the review comments * chore: Update profiles list (#265) * chore: Update profiles list * Addressed the comments * chore: Add profiles:port (#266) * Add profiles:port * Eslint fix * Minor edit * update test * Address review comments * Change nomenclature from porting profiles to porting keys * add space * chore: Throw alert when active profile is not set (#267) * Fetching profile by order if active profile is not set 1. Added the warning when active profile is NULL and no environment variable is set in case of profile create/update. 2. Added/updated the corresponding test cases. * Addressed the comments * chore: change post install messaging behaviour (#269) * feat: Added twilio config to list/set edge configuration (#270) * feat: Added twilio config to list/set edge configuration * Added the missing changes * Addressed the review comments. * Updated the missing messages * Updated the review comments. * Moved the common code functionality to utility. * Added the missing change. * Minor refactoring in the getFromEnvironment method. * chore - Updated package.json to point to cli-core release candidate and cli-test new release (#273) * [chore] - Updating package.json to point to cli-core release candidate and cli-test new release * Removed the cli-test version upgrade. * Added the shortform * Updated the cli-core version. * fix: Update release-feature-branch with main (#275) * update slack token * feat: add assets plugin to available plugins (#261) * [Librarian] Regenerated @ 8ec9e610ad617fae257b54113f6d7fa08c457a87 * Release 2.25.0 * chore: updating plugin-help version (#268) Co-authored-by: kridai <kgoswami@twilio.com> * [Librarian] Regenerated @ 7bffdec2c05f6a34b94cebd095be5b1b30705f5d * Release 2.26.0 * [Librarian] Regenerated @ 54ad9271a294331f8d036e4a3fc173bb98ecdb82 * Release 2.27.0 Co-authored-by: Elmer Thomas <ethomas@twilio.com> Co-authored-by: Phil Nash <pnash@twilio.com> Co-authored-by: Twilio <team_interfaces+github@twilio.com> Co-authored-by: kridai <kridaigoswami@gmail.com> Co-authored-by: kridai <kgoswami@twilio.com> * Updated the cli-core package version with latest. * [Librarian] Regenerated @ 54ad9271a294331f8d036e4a3fc173bb98ecdb82 * Release 2.27.1-rc * chore: Fix autocomplete bugs (#274) Co-authored-by: Shamant Raghav <sraghav@twilio.com> * feat: add new flag support for config commands to force profile input flag (#272) * feat: add new flag support require-profile-input for config commands * updated tests for config set and list * refactor logic for config set * nit, adding comment * changes per review comment, updating the parsing login for config list command * feature: Twilio update (#278) * SR: Oclif Update changes * SR: adding message to alert about the update * minor change Co-authored-by: Shamant Raghav <sraghav@twilio.com> Co-authored-by: Anuj Badhwar <abadhwar@twilio.com> Co-authored-by: Elmer Thomas <ethomas@twilio.com> Co-authored-by: Phil Nash <pnash@twilio.com> Co-authored-by: Twilio <team_interfaces+github@twilio.com> Co-authored-by: kridai <kridaigoswami@gmail.com> Co-authored-by: kridai <kgoswami@twilio.com> Co-authored-by: shamantraghav <87780745+shamantraghav@users.noreply.github.com> Co-authored-by: Shamant Raghav <sraghav@twilio.com>

## [2.33.0-rc.2](2.33.0-rc.1...2.33.0-rc.2) (2021-11-12) ### Library - Fixes * Hardcoding the name of the first part of the package ([#327](#327)) ([67b44cb](67b44cb)), closes [#313](#313) [#312](#312) [#318](#318) [#289](#289) [#287](#287) [#284](#284) [#286](#286) [#285](#285) [#294](#294) [#295](#295) [#293](#293) [#297](#297) [#298](#298) [#301](#301) [#304](#304) [#310](#310) [#306](#306) [#315](#315) [#316](#316) [#289](#289) [#281](#281) [#298](#298) [#287](#287) [#284](#284) [#304](#304) [#312](#312) [#286](#286) [#285](#285) [#283](#283) [#294](#294) [#285](#285) [#279](#279) [#301](#301) [#280](#280) [#313](#313) [#295](#295) [#293](#293) [#310](#310) [#318](#318) [#297](#297) [#306](#306) [#315](#315) [#316](#316) [#321](#321) * Update release feature branch ([#330](#330)) ([5878348](5878348)), closes [#257](#257) [#259](#259) [#262](#262) [#264](#264) [#265](#265) [#266](#266) [#267](#267) [#269](#269) [#270](#270) [#273](#273) [#275](#275) [#261](#261) [#268](#268) [#274](#274) [#272](#272) [#278](#278) * Updated cli-core version with the latest rc tag. ([abe116e](abe116e))

Fetching profile by order if active profile is not set

f11f5e0

1. Added the warning when active profile is NULL and no environment variable is set in case of profile create/update. 2. Added/updated the corresponding test cases.

ravali-rimmalapudi requested review from Sindhura3, onuzbee and childish-sambino July 6, 2021 13:17

ravali-rimmalapudi mentioned this pull request Jul 6, 2021

chore: Throw alert when active profile is not set. twilio/twilio-cli-core#131

Merged

8 tasks

onuzbee reviewed Jul 6, 2021

View reviewed changes

ravali-rimmalapudi mentioned this pull request Jul 6, 2021

chore: Change in Active profile twilio/twilio-cli-test#8

Merged

1 task

Addressed the comments

6b4059f

onuzbee approved these changes Jul 6, 2021

View reviewed changes

Sindhura3 merged commit ceb894c into release-feature-branch Jul 6, 2021

Sindhura3 deleted the DI-1479_active_profile branch July 6, 2021 20:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Throw alert when active profile is not set #267

chore: Throw alert when active profile is not set #267

ravali-rimmalapudi commented Jul 6, 2021 •

edited

Loading

onuzbee Jul 6, 2021

ravali-rimmalapudi Jul 6, 2021

onuzbee Jul 6, 2021

ravali-rimmalapudi Jul 6, 2021

onuzbee left a comment

chore: Throw alert when active profile is not set #267

chore: Throw alert when active profile is not set #267

Conversation

ravali-rimmalapudi commented Jul 6, 2021 • edited Loading

Fixes

Checklist

onuzbee Jul 6, 2021

Choose a reason for hiding this comment

ravali-rimmalapudi Jul 6, 2021

Choose a reason for hiding this comment

onuzbee Jul 6, 2021

Choose a reason for hiding this comment

ravali-rimmalapudi Jul 6, 2021

Choose a reason for hiding this comment

onuzbee left a comment

Choose a reason for hiding this comment

ravali-rimmalapudi commented Jul 6, 2021 •

edited

Loading