chore: Fix autocomplete bugs #274

sr010 · 2021-07-29T07:33:17Z

Closes :

DI-754
DII-5

Screenshot for DI-754:

When plugins:update is run:

When any other command is run:

Screenshot for DII-5:

When autocomplete is run without the shell:

When autocomplete is run with the shell:

Fixes

A short description of what this PR does.

Checklist

I acknowledge that all my contributions will be made under the project's license
I have made a material change to the repo (functionality, testing, spelling, grammar)
I have read the Contribution Guidelines and my PR follows them
I have titled the PR appropriately
I have updated my branch with the main branch
I have added tests that prove my fix is effective or that my feature works
I have added the necessary documentation about the functionality in the appropriate .md file
I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

SR: Anding changes to fix the 2 issues

package.json

sr010 · 2021-07-29T10:38:38Z

src/hooks/postrun/plugin-postrun.js

+
+module.exports = async function pluginPostRun(options) {
+  // console.log(options);
+  if (options.Command.id === 'plugins:update') {


This is the custom event triggered.

Once postrun is triggered, we check if the "plugins:update" command is run and display the necessary warnings.

Similarly we do a check for the autocomplete command

onuzbee · 2021-07-29T10:24:51Z

src/hooks/postrun/plugin-postrun.js

+)} or ${chalk.bold('twilio autocomplete zsh')}`;
+
+module.exports = async function pluginPostRun(options) {
+  // console.log(options);


Can be removed?

onuzbee · 2021-07-29T10:37:34Z

src/services/post-install-utility.js

@@ -48,11 +52,13 @@ class PostInstallDisplayManager {

    if (this.hasProjects()) {
      console.warn(chalk.yellowBright(` » ${PORT_WARNING}`));
+      console.warn(chalk.yellowBright(` » ${AUTOCOMLETE_WARNING}`));


Should we not display autocomplete warning for a fresh install with no profiles configured as well? I might be out of context here, but I think it shouldn't be check based as what I could see from the ask, and should display this autocomplete warning for every install.

Nice spot! Made the change

onuzbee · 2021-07-29T10:38:08Z

src/hooks/postrun/plugin-postrun.js

@@ -0,0 +1,22 @@
+/* eslint-disable no-console */
+const { logger } = require('@twilio/cli-core').services.logging;


Not required

sr010 · 2021-07-29T10:39:25Z

src/services/post-install-utility.js

@@ -7,6 +7,10 @@ const PORT_WARNING = `Profiles exist with API keys in system keychain. Please ru
  'twilio profiles:port',
 )} to port all keys to the config file`;

+const AUTOCOMLETE_WARNING = `If you’re using autocomplete, you’ll need to run ${chalk.bold(


Adding the autocomplete warning for when the cli is updated

src/hooks/postrun/plugin-postrun.js

Sindhura3

Well done on the first PR! LGTM

shrutiburman

Looks good! 🚀

onuzbee

🚀 Good work!

kridai

👍

* chore: Refactor profiles usage to projects (#257) * chore: Store API Keys in Config File (#259) * Save to config and not keytar * Remove secure storage references * Remove keytar load * Remove unnecessary ref to secureStorage * Correct logging * Remove dependent test failures * Add todos * chore: CLI Profile Remove - Check and Use config file before checking system keychain. (#262) * chore: CLI Profile Update - Using config file instead of the system keychain (#264) * chore: CLI Profile Update - Using config file instead of the system keychain * Added the test cases. * Addressed the review comments * Added the missing alignment. * Addressed the review comments * chore: Update profiles list (#265) * chore: Update profiles list * Addressed the comments * chore: Add profiles:port (#266) * Add profiles:port * Eslint fix * Minor edit * update test * Address review comments * Change nomenclature from porting profiles to porting keys * add space * chore: Throw alert when active profile is not set (#267) * Fetching profile by order if active profile is not set 1. Added the warning when active profile is NULL and no environment variable is set in case of profile create/update. 2. Added/updated the corresponding test cases. * Addressed the comments * chore: change post install messaging behaviour (#269) * feat: Added twilio config to list/set edge configuration (#270) * feat: Added twilio config to list/set edge configuration * Added the missing changes * Addressed the review comments. * Updated the missing messages * Updated the review comments. * Moved the common code functionality to utility. * Added the missing change. * Minor refactoring in the getFromEnvironment method. * chore - Updated package.json to point to cli-core release candidate and cli-test new release (#273) * [chore] - Updating package.json to point to cli-core release candidate and cli-test new release * Removed the cli-test version upgrade. * Added the shortform * Updated the cli-core version. * fix: Update release-feature-branch with main (#275) * update slack token * feat: add assets plugin to available plugins (#261) * [Librarian] Regenerated @ 8ec9e610ad617fae257b54113f6d7fa08c457a87 * Release 2.25.0 * chore: updating plugin-help version (#268) Co-authored-by: kridai <kgoswami@twilio.com> * [Librarian] Regenerated @ 7bffdec2c05f6a34b94cebd095be5b1b30705f5d * Release 2.26.0 * [Librarian] Regenerated @ 54ad9271a294331f8d036e4a3fc173bb98ecdb82 * Release 2.27.0 Co-authored-by: Elmer Thomas <ethomas@twilio.com> Co-authored-by: Phil Nash <pnash@twilio.com> Co-authored-by: Twilio <team_interfaces+github@twilio.com> Co-authored-by: kridai <kridaigoswami@gmail.com> Co-authored-by: kridai <kgoswami@twilio.com> * Updated the cli-core package version with latest. * [Librarian] Regenerated @ 54ad9271a294331f8d036e4a3fc173bb98ecdb82 * Release 2.27.1-rc * chore: Fix autocomplete bugs (#274) Co-authored-by: Shamant Raghav <sraghav@twilio.com> * feat: add new flag support for config commands to force profile input flag (#272) * feat: add new flag support require-profile-input for config commands * updated tests for config set and list * refactor logic for config set * nit, adding comment * changes per review comment, updating the parsing login for config list command * feature: Twilio update (#278) * SR: Oclif Update changes * SR: adding message to alert about the update * minor change Co-authored-by: Shamant Raghav <sraghav@twilio.com> Co-authored-by: Anuj Badhwar <abadhwar@twilio.com> Co-authored-by: Elmer Thomas <ethomas@twilio.com> Co-authored-by: Phil Nash <pnash@twilio.com> Co-authored-by: Twilio <team_interfaces+github@twilio.com> Co-authored-by: kridai <kridaigoswami@gmail.com> Co-authored-by: kridai <kgoswami@twilio.com> Co-authored-by: shamantraghav <87780745+shamantraghav@users.noreply.github.com> Co-authored-by: Shamant Raghav <sraghav@twilio.com>

## [2.33.0-rc.2](2.33.0-rc.1...2.33.0-rc.2) (2021-11-12) ### Library - Fixes * Hardcoding the name of the first part of the package ([#327](#327)) ([67b44cb](67b44cb)), closes [#313](#313) [#312](#312) [#318](#318) [#289](#289) [#287](#287) [#284](#284) [#286](#286) [#285](#285) [#294](#294) [#295](#295) [#293](#293) [#297](#297) [#298](#298) [#301](#301) [#304](#304) [#310](#310) [#306](#306) [#315](#315) [#316](#316) [#289](#289) [#281](#281) [#298](#298) [#287](#287) [#284](#284) [#304](#304) [#312](#312) [#286](#286) [#285](#285) [#283](#283) [#294](#294) [#285](#285) [#279](#279) [#301](#301) [#280](#280) [#313](#313) [#295](#295) [#293](#293) [#310](#310) [#318](#318) [#297](#297) [#306](#306) [#315](#315) [#316](#316) [#321](#321) * Update release feature branch ([#330](#330)) ([5878348](5878348)), closes [#257](#257) [#259](#259) [#262](#262) [#264](#264) [#265](#265) [#266](#266) [#267](#267) [#269](#269) [#270](#270) [#273](#273) [#275](#275) [#261](#261) [#268](#268) [#274](#274) [#272](#272) [#278](#278) * Updated cli-core version with the latest rc tag. ([abe116e](abe116e))

sr010 added 2 commits July 29, 2021 12:46

DII-5 and DI-754 fix

36020c0

SR: Anding changes to fix the 2 issues

Removing comment

3e2bd3d

sr010 requested review from onuzbee, Sindhura3, ravali-rimmalapudi, kridai and shrutiburman July 29, 2021 09:05

sr010 changed the title ~~chore:~~ chore: Fix autocomplete bugs Jul 29, 2021

sr010 commented Jul 29, 2021

View reviewed changes

package.json Show resolved Hide resolved

sr010 commented Jul 29, 2021

View reviewed changes

onuzbee reviewed Jul 29, 2021

View reviewed changes

sr010 commented Jul 29, 2021

View reviewed changes

kridai reviewed Jul 29, 2021

View reviewed changes

src/hooks/postrun/plugin-postrun.js Outdated Show resolved Hide resolved

Addressing review comments

cf5c2fc

Sindhura3 approved these changes Jul 30, 2021

View reviewed changes

shrutiburman approved these changes Jul 30, 2021

View reviewed changes

onuzbee approved these changes Jul 30, 2021

View reviewed changes

kridai self-requested a review July 30, 2021 05:44

kridai approved these changes Jul 30, 2021

View reviewed changes

onuzbee merged commit fbb8fc9 into twilio:release-feature-branch Jul 30, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Fix autocomplete bugs #274

chore: Fix autocomplete bugs #274

sr010 commented Jul 29, 2021 •

edited

Loading

sr010 Jul 29, 2021 •

edited

Loading

onuzbee Jul 29, 2021

sr010 Jul 29, 2021

onuzbee Jul 29, 2021

sr010 Jul 29, 2021

onuzbee Jul 29, 2021

sr010 Jul 29, 2021

sr010 Jul 29, 2021

Sindhura3 left a comment

shrutiburman left a comment

onuzbee left a comment

kridai left a comment

		@@ -0,0 +1,22 @@
		/* eslint-disable no-console */
		const { logger } = require('@twilio/cli-core').services.logging;

chore: Fix autocomplete bugs #274

chore: Fix autocomplete bugs #274

Conversation

sr010 commented Jul 29, 2021 • edited Loading

Fixes

Checklist

sr010 Jul 29, 2021 • edited Loading

Choose a reason for hiding this comment

onuzbee Jul 29, 2021

Choose a reason for hiding this comment

sr010 Jul 29, 2021

Choose a reason for hiding this comment

onuzbee Jul 29, 2021

Choose a reason for hiding this comment

sr010 Jul 29, 2021

Choose a reason for hiding this comment

onuzbee Jul 29, 2021

Choose a reason for hiding this comment

sr010 Jul 29, 2021

Choose a reason for hiding this comment

sr010 Jul 29, 2021

Choose a reason for hiding this comment

Sindhura3 left a comment

Choose a reason for hiding this comment

shrutiburman left a comment

Choose a reason for hiding this comment

onuzbee left a comment

Choose a reason for hiding this comment

kridai left a comment

Choose a reason for hiding this comment

sr010 commented Jul 29, 2021 •

edited

Loading

sr010 Jul 29, 2021 •

edited

Loading