Skip to content

Remove the code in the algorithm that boosts the tweets of Elon #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Remove the code in the algorithm that boosts the tweets of Elon #160

wants to merge 3 commits into from

Conversation

elvodqa
Copy link

@elvodqa elvodqa commented Mar 31, 2023

The title is self-explanatory.

@JoshuaLuckers
Copy link

LGTM ;)

@JuanPablo2655
Copy link

lol

@josemaia
Copy link

Duplicate #138

@sunglocto
Copy link

lgtm

@elvodqa
Copy link
Author

elvodqa commented Mar 31, 2023

Duplicate #138

Damn that was fast.

@acgfbr
Copy link

acgfbr commented Mar 31, 2023

merge

@ghost
Copy link

ghost commented Mar 31, 2023

lgtm, no more elon!

@jplie
Copy link

jplie commented Mar 31, 2023

no more elon ((

@OffenLord
Copy link

LGTM

@elvodqa
Copy link
Author

elvodqa commented Mar 31, 2023

Politics should also be removed in my humble opinion

@mohammedsahl
Copy link

LGTM! Feel free to merge

@VrindavanSanap
Copy link

LOLL😂😂

@elvodqa
Copy link
Author

elvodqa commented Mar 31, 2023

Done!!! Any devs willing to check my pr?

@dev-bun
Copy link

dev-bun commented Mar 31, 2023

lgtm

@NateShoffner
Copy link

LGTM

Copy link

@bee-san bee-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Looking into it.

Copy link

@MickaelCa MickaelCa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garrettsutula
Copy link

LGTM ✅

Copy link

@acarlson99 acarlson99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, perhaps consider removing other references to ElonFeature :)

https://github.com/twitter/the-algorithm/search?q=DDGStatsElonFeature

@dev-bun
Copy link

dev-bun commented Mar 31, 2023

Personally I think we should just clear the entire codebase and just rm -rf /* the site. Simple, effective, and removes all problems.

@martynix
Copy link

:))))

@dromzeh
Copy link

dromzeh commented Mar 31, 2023

LGTM

@iakat
Copy link

iakat commented Mar 31, 2023

posting in an epic thread

@ryanbnl
Copy link

ryanbnl commented Mar 31, 2023

Someone give me merge rights and we're go!

@cjoelrun
Copy link

Can someone explain how is this used in the algorithm? Looks like it sets up a predicate for Elon that's only later referenced in metrics:

/**
* These author ID lists are used purely for metrics collection. We track how often we are
* serving Tweets from these authors and how often their tweets are being impressed by users.
* This helps us validate in our A/B experimentation platform that we do not ship changes
* that negatively impacts one group over others.
*/
.add(DDGStatsDemocratsFeature, ddgStatsAuthors.longSeq(Democrats).toSet)
.add(DDGStatsRepublicansFeature, ddgStatsAuthors.longSeq(Republicans).toSet)
.add(DDGStatsVitsFeature, ddgStatsAuthors.longSeq(Vits).toSet)
.add(DDGStatsElonFeature, ddgStatsAuthors.longValue(Elon))

@thiagopos
Copy link

thiagopos commented Mar 31, 2023

LGTM!

@CLAassistant
Copy link

CLAassistant commented Mar 31, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ twitter-team
❌ elvodqa


twitter-team seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mar-pan
Copy link

mar-pan commented Mar 31, 2023

awaited feature, please ship it 🥳

@Scribilicious
Copy link

When will it be merged?

@rguzg
Copy link

rguzg commented Apr 1, 2023

LGTM

@ghost
Copy link

ghost commented Apr 1, 2023

haha or delete Elon account

@harrrshall
Copy link

elon be like gjb bezzati hai

@amrityam
Copy link

amrityam commented Apr 1, 2023

LGTM

@jangels
Copy link

jangels commented Oct 25, 2023

🤩, LGTM, lol, mask angry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.