Skip to content

Refactor navi/dr_transform #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2023
Merged

Refactor navi/dr_transform #452

merged 2 commits into from
Apr 4, 2023

Conversation

pouriya
Copy link
Contributor

@pouriya pouriya commented Mar 31, 2023

Refactor

  • Clippy issues.
  • Macros parameters.

Features

  • filename:line in file reader error message.

@CLAassistant
Copy link

CLAassistant commented Apr 1, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ElijahPepe
Copy link

LGTM.

@dzhao dzhao merged commit 36588c6 into twitter:main Apr 4, 2023
twitter-service pushed a commit that referenced this pull request Apr 28, 2023
Latest navi open source refresh
4df87a2 
latest code change including the global thread pool

Closes #452
Closes #505
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dzhao dzhao dzhao approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pouriya @CLAassistant @ElijahPepe @dzhao @UtsavBalar1231