Skip to content

Refactor navi/segdense #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Refactor navi/segdense #505

wants to merge 4 commits into from

Conversation

pouriya
Copy link
Contributor

@pouriya pouriya commented Apr 1, 2023

Refactors

  • Avoid cloning seg_dense::Root here.
  • Clippy issues.
  • Macros parameters.
  • Update style.

@CLAassistant
Copy link

CLAassistant commented Apr 1, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dzhao
Copy link
Contributor

dzhao commented Apr 4, 2023

Thanks for the suggestion. Removing of clone requires a bit more refactoring as upper project is using it. Will not merge this time but would fix in our source code and copy over

@dzhao dzhao closed this Apr 4, 2023
@pouriya
Copy link
Contributor Author

pouriya commented Apr 4, 2023

Can I send a fix to that or I should wait for your updates?

twitter-service pushed a commit that referenced this pull request Apr 28, 2023
Latest navi open source refresh
4df87a2 
latest code change including the global thread pool

Closes #452
Closes #505
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pouriya @CLAassistant @dzhao