Update json4s version to 4.0.3 and factor into val #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
hey @ggrossman, please sign the contributor license agreement so we can get started on merging this. Thanks! |
|
Hi @joybestourous , thanks for looking at this. We'll sign the CLA as soon as possible. Our legal department is reviewing the CLA. Happy holidays! |
|
@joybestourous CLA is signed! |
Codecov Report
@@ Coverage Diff @@
## develop #297 +/- ##
===========================================
- Coverage 52.63% 52.61% -0.02%
===========================================
Files 318 318
Lines 16870 16870
Branches 1046 1036 -10
===========================================
- Hits 8879 8876 -3
- Misses 7991 7994 +3
Continue to review full report at Codecov.
|
finaglehelper
pushed a commit
to twitter/finatra
that referenced
this pull request
Dec 17, 2021
**Problem**
The latest version of json4s is 4.0.3.
finatra depends on json4s 3.6.11.
util-jackson depends on json4s 3.6.11, and util-validator depends on json4s 3.6.7. (Seems like an accident that these are different.)
Other popular libraries, such as jwt-scala, now depend on json4s 4.0.3. This creates binary compatibility problems when Twitter Util is used in conjunction with these libraries:
```
[error] * org.json4s:json4s-core_2.12:4.0.3 (early-semver) is selected over {3.6.11, 3.6.11, 3.6.11, 3.6.7}
[error] +- com.github.jwt-scala:jwt-json4s-common_2.12:9.0.2 (depends on 4.0.3)
[error] +- com.twitter:util-validator_2.12:21.11.0 (depends on 3.6.7)
[error] +- com.twitter:util-jackson_2.12:21.11.0 (depends on 3.6.11)
[error] +- com.twitter:finatra-validation_2.12:21.11.0 (depends on 3.6.11)
[error] +- com.twitter:finatra-jackson_2.12:21.11.0 (depends on 3.6.11)
[error]
```
**Solution**
Twitter Util should bump to json4s 4.0.3. I know that all libraries in the Twitter Stack bump these dependencies at the same time, so I have also provided a PR for Finatra. bijection is already on json4s 4.0.3. scrooge and finagle do not depends on json4s.
sbt test succeeds with json4s 4.0.3 and no other code changes.
I took the liberty of creating a val json4sVersion instead of having the version number separately in util-jackson and util-validator... this should help to keep them in sync in the future.
**Result**
Closes twitter/util#297
Closes #572
Signed-off-by: Joy Bestourous <jbestourous@twitter.com>
Differential Revision: https://phabricator.twitter.biz/D803847
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The latest version of json4s is 4.0.3.
util-jackson depends on json4s 3.6.11, and util-validator depends on json4s 3.6.7. (Seems like an accident that these are different.)
Other popular libraries, such as jwt-scala, now depend on json4s 4.0.3. This creates binary compatibility problems when Twitter Util is used in conjunction with these libraries:
Solution
Twitter Util should bump to json4s 4.0.3. I know that all libraries in the Twitter Stack bump these dependencies at the same time, so I have also provided a PR for Finatra. bijection is already on json4s 4.0.3. scrooge and finagle do not depend on json4s.
sbt testsucceeds with json4s 4.0.3 and no other code changes.I took the liberty of creating a
val json4sVersioninstead of having the version number separately in util-jackson and util-validator... this should help to keep them in sync in the future.