Skip to content

Commit 23ce949

Browse files
vmaxGaneshwara Herawan Hananda
authored andcommitted
Fix RPM package name (#183)
## What is the goal of this PR? Fix #180 If `workspace_refs` was passed to `assemble_rpm`, RPM package name would be invalid. ## What are the changes implemented in this PR? `tag` which is attached to indicate RPM package name should be attached _before_ spec file is modified.
1 parent 0065b12 commit 23ce949

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

rpm/rules.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ def assemble_rpm(name,
6767
symlinks: mapping between source and target of symbolic links
6868
created at installation
6969
"""
70+
tag = "rpm_package_name={}".format(spec_file.split(':')[-1].replace('.spec', ''))
7071
tar_name = "_{}-rpm-tar".format(package_name)
7172

7273
rpm_data = []
@@ -140,7 +141,6 @@ def assemble_rpm(name,
140141
"//conditions:default": ""
141142
})
142143
)
143-
tag = "rpm_package_name={}".format(spec_file.split(':')[-1].replace('.spec', ''))
144144

145145
native.genrule(
146146
name = name,

0 commit comments

Comments
 (0)