Fix type of <fieldname>_id when using ForeignKey(to_field=) #1176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously mypy_django_plugin would always use the field type of target model's primary key, but `to_field` can refer to a different field type.
intgr
commented
Sep 29, 2022
| if to_field_name: | ||
| rel_field = related_model_cls._meta.get_field(to_field_name) | ||
| if not isinstance(rel_field, Field): | ||
| return None # Not supported |
There was a problem hiding this comment.
If it's referring to a non-field, Django system checks would probably throw an error. I could also use assert here.
|
@sobolevn Thanks for your continued maintenance. There is already tons of good stuff merged in django-stubs, any plans for a release? |
|
Yes! Soon :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously mypy_django_plugin would always use the field type of target model's primary key, but
to_fieldcan refer to a different field type.