Fix type of <fieldname>_id in query lookups when using ForeignKey(to_field=) #1179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
requested changes
Oct 2, 2022
| class UUIDField(Field[_ST, _GT]): | ||
| _pyi_private_set_type: Union[str, uuid.UUID] | ||
| _pyi_private_get_type: uuid.UUID | ||
| _pyi_lookup_exact_type: Union[uuid.UUID, str] |
There was a problem hiding this comment.
Unrelated, merged in a different PR.
intgr
added
the
stale
|
What needs to be done to progress this one? I've just hit #997 and would love to be able to resolve that, which I think this does. |
|
Sorry for dropping the ball here. Ugh, the rebase will be messy. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to #1176, but applies to query lookups instead of model attribute access.
This should be merged after #1178.