Skip to content

Use ESNext target for twoslash #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2024
Merged

Use ESNext target for twoslash #229

merged 1 commit into from
Jun 19, 2024

Conversation

mkantor
Copy link
Contributor

@mkantor mkantor commented May 20, 2024

As suggested here.

robertt
robertt approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@robertt robertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @tjjfvi you touched this most recently - all look good?

@mkantor
Copy link
Contributor Author

mkantor commented Jun 19, 2024

@robertt is this shippable now that @tjjfvi reviewed?

@robertt
Copy link
Member

robertt commented Jun 19, 2024

Thx for the bump!

@robertt robertt merged commit 02b8dc2 into typescript-community:master Jun 19, 2024
@mkantor mkantor deleted the newer-twoslash-target branch June 19, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertt robertt robertt approved these changes

+1 more reviewer

@tjjfvi tjjfvi tjjfvi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkantor @robertt @tjjfvi